Conversation
Fixes 8 asgard findings from the GovTechSG-oobee-scan-2026-09-14 review:
- asgard-0001 (high): route github.ref_name and version outputs through
validated env: blocks in bump-package-version.yml to close the GitHub
Actions script-injection vector.
- asgard-0002 / asgard-0003 (high): stage the veraPDF izpack install into
a per-user, non-predictable directory (Windows: random subdir under
$env:TEMP; macOS: mktemp -d) instead of the shared C:\Windows\Temp
and /tmp/verapdf paths. Rewrite verapdf-auto-install-{windows,macos}.xml
at install time so the placeholder resolves to the private path. Scope
the recursive `xattr -rd com.apple.quarantine` to just the trees oobee
installed (nodejs-mac-*, jre, verapdf) rather than the whole cwd.
- asgard-0004 (medium): add isInternalOrLoopbackUrl and a
Response.serverAddr() DNS-rebinding check to the crawlDomain
pre/post-navigation hooks so untrusted discovered links can no longer
steer the crawler at 169.254.169.254 / 127.0.0.1 / RFC1918. Also add
an opt-in OOBEE_BLOCK_INTERNAL_TARGETS seed-URL gate for hosted
deployments.
- asgard-0005 (medium): mirror runCustom's hasCredentials formula in
crawlSitemap so Bearer / non-Basic Authorization headers keep TLS
validation on when OOBEE_ALLOW_INSECURE_TLS is set.
- asgard-0006 (medium): render generateGenAiSuggestFix error messages
via textContent instead of innerHTML so an attacker-influenced AI
error field cannot execute script in the report DOM.
- asgard-0007 (medium): honour OOBEE_DISABLE_TELEMETRY in
sendWcagBreakdownToSentry so the opt-out actually stops PII (email,
name, entry URL) from reaching Sentry.
- asgard-0009 (info): install Chrome via Google's signed apt repository
(with the linux_signing_key.pub optionally pinnable by SHA-256) for
both amd64 and arm64, replacing the unverified google-chrome-stable_current .deb wget.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses 8 asgard findings from the GovTechSG-oobee-scan-2026-09-14 review (3 high, 4 medium, 1 info).
github.ref_nameand step outputs through validatedenv:blocks inbump-package-version.yml(script-injection).$env:TEMP(notC:\Windows\Temp).mktemp -d(not/tmp/verapdf);xattr -rd com.apple.quarantinescoped to just the trees oobee installs.isInternalOrLoopbackUrlpre-nav filter +Response.serverAddr()post-nav DNS-rebinding check incrawlDomain; opt-inOOBEE_BLOCK_INTERNAL_TARGETSseed-URL gate.crawlSitemapmirrorsrunCustom:hasCredentials = \!\!authHeader || \!\!httpCredentials, so Bearer tokens keep TLS validation on whenOOBEE_ALLOW_INSECURE_TLSis set.generateGenAiSuggestFixerror path renders viatextContent/replaceChildreninstead ofinnerHTML.sendWcagBreakdownToSentryshort-circuits whenOOBEE_DISABLE_TELEMETRYis set.--build-arg GOOGLE_CHROME_SIGNING_KEY_SHA256pin.Not addressed (intentional):
Test plan
npm run buildsucceeds (tsc + copyfiles)tsc --noEmitcleanbash -non modified shell scriptsxmllint --noouton modified XML filesyaml.safe_loadon modified workflowOOBEE_BLOCK_INTERNAL_TARGETS=1to confirm gate behaviourJest suite is currently broken on master (missing
../utils.js, missingmustache, CJS lexer errors); unrelated to this PR.🤖 Generated with Claude Code