Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
23a1f86
chore(deps-dev): bump hono from 4.12.14 to 4.12.18
dependabot[bot] May 8, 2026
b109bb9
chore(deps-dev): bump fast-uri from 3.1.0 to 3.1.2
dependabot[bot] May 9, 2026
4d2e6a3
chore(deps): bump @babel/plugin-transform-modules-systemjs
dependabot[bot] May 9, 2026
9888f8c
chore(deps): bump devalue from 5.6.4 to 5.8.1
dependabot[bot] May 14, 2026
06e54b0
chore(#3770): generate MCP data from docs site content
twjeffery May 19, 2026
f51b477
chore(#3770): recurse into nested example folders
twjeffery May 20, 2026
227bb97
chore(#3770): resolve guidance references through component aliases
twjeffery May 20, 2026
519121a
chore(#3770): derive canonical svelte from react wrapper
twjeffery May 20, 2026
eb5ce64
chore(#3770): model table-sort-header as its own component
twjeffery May 20, 2026
0c5950a
chore(#3770): clear stale output files before writing
twjeffery May 20, 2026
b83f602
docs(#3877): Update Designing with Design System page
Spark450 May 20, 2026
0154662
fix(#3679): Add border-box css directives for Table
willcodeforcoffee May 21, 2026
60f1acb
chore(#3770): stop preserving absent entries on re-extraction
twjeffery May 21, 2026
261e93a
fix(#3932): fix tooltip position on Work Side Menu
bdfranck May 12, 2026
9450113
chore(deps): bump qs and express
dependabot[bot] May 22, 2026
b26f900
fix(#3854): Hide empty menu slots for Work Side Menu in Angular
bdfranck May 25, 2026
03cfe65
chore(#3770): read framework identifiers from source, not naming conv…
twjeffery May 26, 2026
3b35e85
chore(#3770): parse YAML block scalars in the frontmatter loader
twjeffery May 26, 2026
84c9616
Merge pull request #3956 from GovAlta/tom/docs-content-generators
twjeffery May 26, 2026
01b2668
Merge pull request #3927 from GovAlta/dependabot/npm_and_yarn/babel/p…
willcodeforcoffee May 26, 2026
c474cdd
doc(#3924): add dark mode experimental section to homepage
Spark450 May 27, 2026
a007a53
docs(#3876): replace related guidance with next steps by role on migr…
Spark450 May 27, 2026
ea3e671
Merge pull request #3944 from GovAlta/dependabot/npm_and_yarn/devalue…
willcodeforcoffee May 27, 2026
6ae15f9
Merge pull request #3926 from GovAlta/dependabot/npm_and_yarn/fast-ur…
willcodeforcoffee May 27, 2026
ee6d639
Merge pull request #3925 from GovAlta/dependabot/npm_and_yarn/hono-4.…
willcodeforcoffee May 27, 2026
b307e68
Merge pull request #3973 from GovAlta/dependabot/npm_and_yarn/multi-f…
willcodeforcoffee May 27, 2026
036d4b7
fix(#3972): add Acumin Variable typeface
bdfranck May 28, 2026
7e03fed
chore: increase fake timer times in Work Side Menu browser tests
bdfranck May 28, 2026
12d5e3b
fix(#3323): use anchor/fixed positioning for Tooltip
bdfranck May 28, 2026
f9a30cb
chore: prevent PR check from hanging on playwright browser download
vanessatran-ddi Jun 1, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,26 @@ on:
jobs:
build:
runs-on: ubuntu-latest
timeout-minutes: 30
container:
image: mcr.microsoft.com/playwright:v1.59.0-noble

env:
# the playwright npm postinstall not to download them during `npm ci`.
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: "1"
# The container runs as root but GitHub sets HOME=/github/home, which the
# image owns as `pwuser`. Firefox refuses to launch when $HOME is owned by a
# different user, so point HOME at root's own home.
HOME: /root

steps:
- uses: actions/checkout@v5
with:
fetch-depth: 0

- name: Allow git to use the container workspace
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"

- uses: actions/setup-node@v6
with:
node-version: "24"
Expand All @@ -39,6 +53,5 @@ jobs:
- name: Test
run: |
if [ -d "./dist" ]; then
npx playwright install --with-deps
npm run test:pr
fi
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ NOTES.md
/test-results
__screenshots__
docs/.astro
docs/generated/mcp/
docs/generated/md-bundle/

# environment
.env
Expand Down
95 changes: 95 additions & 0 deletions apps/prs/angular/src/routes/bugs/3679/bug3679.component.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
<div>
<h1>Bug 3679: Table: 1px horizontal overflow from v2 border</h1>
<p>
The V2 table container has <code>width: 100%</code> (inline style) and
<code>border: 1px solid</code> but no <code>box-sizing: border-box</code>. The border adds 2px to the total rendered
width, causing 1px horizontal scroll on both sides.
</p>
<goab-container>
<h2>Test inside GoabContainer</h2>
<goab-table version="2" width="100%">
<thead>
<tr>
<th>First Name</th>
<th>Last Name</th>
<th>Job</th>
</tr>
</thead>
<tbody>
<tr>
<td>Joey</td>
<td>Tribbiani</td>
<td>Actor</td>
</tr>
<tr>
<td>Chandler</td>
<td>Bing</td>
<td>Statistical Analysis and Data Reconfiguration</td>
</tr>
<tr>
<td>Ross</td>
<td>Geller</td>
<td>Paleontologist</td>
</tr>
</tbody>
</goab-table>
</goab-container>
<div style="margin-top: 1rem; width: 40%;">
<h2>Test inside div with width 40%</h2>
<goab-table version="2" width="100%">
<thead>
<tr>
<th>First Name</th>
<th>Last Name</th>
<th>Job</th>
</tr>
</thead>
<tbody>
<tr>
<td>Rachel</td>
<td>Green</td>
<td>Barrista</td>
</tr>
<tr>
<td>Monica</td>
<td>Geller</td>
<td>Chef</td>
</tr>
<tr>
<td>Phoebe</td>
<td>Buffay</td>
<td>Musician</td>
</tr>
</tbody>
</goab-table>
</div>
<div style="margin-top: 1rem; width: 600px; background-color: #fff8e1; outline: 2px dashed #ffa000;">
<h2 style="margin: 0; padding: 0.5rem;">Test inside fixed 600px container (table should fill container exactly)</h2>
<goab-table version="2" width="100%">
<thead>
<tr>
<th>First Name</th>
<th>Last Name</th>
<th>Job</th>
</tr>
</thead>
<tbody>
<tr>
<td>Carol</td>
<td>Willick</td>
<td>Teacher</td>
</tr>
<tr>
<td>Gunther</td>
<td>Centralperk</td>
<td>Barista</td>
</tr>
<tr>
<td>Janice</td>
<td>Litman</td>
<td>Sales</td>
</tr>
</tbody>
</goab-table>
</div>
</div>
10 changes: 10 additions & 0 deletions apps/prs/angular/src/routes/bugs/3679/bug3679.component.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { Component } from "@angular/core";
import { GoabContainer, GoabTable } from "@abgov/angular-components";

@Component({
standalone: true,
selector: "abgov-bug3679",
templateUrl: "./bug3679.component.html",
imports: [GoabContainer, GoabTable],
})
export class Bug3679Component {}
6 changes: 6 additions & 0 deletions apps/prs/angular/src/routes/bugs/3679/bug3679.route.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"title": "Table: 1px horizontal overflow from v2 border",
"path": "bugs/3679",
"id": "3679",
"type": "bug"
}
44 changes: 44 additions & 0 deletions apps/prs/angular/src/routes/bugs/3854/bug3854.component.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<goab-text tag="h1" mb="m">Bug 3854 - Work Side Menu without extra sections</goab-text>
<goab-text mb="xl">
This test page renders a Work Side Menu with only primary content. Confirm the
following:
<ul>
<li>The primary menu is visible.</li>
<li>The secondary and account menu is hidden.</li>
</ul>
</goab-text>

<div
style="
max-width: 20rem;
border: 1px solid #ddd;
min-height: 28rem;
--goa-work-side-menu-height: 400px;
"
>
<goab-work-side-menu
heading="Primary-only menu"
url="/bugs/3854"
[open]="true"
(onNavigate)="handleNavigate($event)"
[primaryContent]="primaryContent"
></goab-work-side-menu>
</div>

<ng-template #primaryContent>
<goab-work-side-menu-item
icon="home"
label="Dashboard"
url="/bugs/3854"
></goab-work-side-menu-item>
<goab-work-side-menu-item
icon="list"
label="Cases"
url="/bugs/3854"
></goab-work-side-menu-item>
<goab-work-side-menu-item
icon="settings"
label="Settings"
url="/bugs/3854"
></goab-work-side-menu-item>
</ng-template>
18 changes: 18 additions & 0 deletions apps/prs/angular/src/routes/bugs/3854/bug3854.component.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { Component } from "@angular/core";
import {
GoabText,
GoabWorkSideMenu,
GoabWorkSideMenuItem,
} from "@abgov/angular-components";

@Component({
standalone: true,
selector: "abgov-bug3854",
templateUrl: "./bug3854.component.html",
imports: [GoabText, GoabWorkSideMenu, GoabWorkSideMenuItem],
})
export class Bug3854Component {
handleNavigate(_path: string): void {
// Intentionally no-op for visual verification.
}
}
6 changes: 6 additions & 0 deletions apps/prs/angular/src/routes/bugs/3854/bug3854.route.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bug",
"id": "3854",
"path": "bugs/3854",
"title": "Work Side Menu without secondary/account"
}
50 changes: 50 additions & 0 deletions apps/prs/angular/src/routes/bugs/3932/bug3932.component.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
<div style="--goa-work-side-menu-height: 500px">
<goab-block gap="m" direction="column">
<goab-text tag="h1" mt="m">Bug #3932: Work Side Menu tooltips</goab-text>
<goab-text tag="span">
This page renders a closed Work Side Menu so tooltip behavior can be tested
manually.
</goab-text>
<goab-text tag="span">
Move between multiple items and confirm each tooltip appears in the correct
position and shows the matching label.
</goab-text>

<goab-work-side-menu
heading="Bug 3932"
url="#"
[open]="false"
[primaryContent]="primaryContentTpl"
[secondaryContent]="secondaryContentTpl"
>
</goab-work-side-menu>
</goab-block>
</div>

<ng-template #primaryContentTpl>
<goab-work-side-menu-item icon="home" label="Dashboard" url="#dashboard">
</goab-work-side-menu-item>
<goab-work-side-menu-item icon="search" label="Search" url="#search">
</goab-work-side-menu-item>
<goab-work-side-menu-item icon="document" label="Reports" url="#reports">
</goab-work-side-menu-item>
<goab-work-side-menu-group heading="Applications" icon="folder" [open]="true">
<goab-work-side-menu-item label="New applications" url="#new-applications">
</goab-work-side-menu-item>
<goab-work-side-menu-item label="In progress" url="#in-progress">
</goab-work-side-menu-item>
<goab-work-side-menu-item label="Approved" url="#approved">
</goab-work-side-menu-item>
</goab-work-side-menu-group>
</ng-template>

<ng-template #secondaryContentTpl>
<goab-work-side-menu-item icon="help-circle" label="Get support" url="#support">
</goab-work-side-menu-item>
<goab-work-side-menu-item
icon="information-circle"
label="Release notes"
url="#release-notes"
>
</goab-work-side-menu-item>
</ng-template>
22 changes: 22 additions & 0 deletions apps/prs/angular/src/routes/bugs/3932/bug3932.component.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { Component } from "@angular/core";
import {
GoabBlock,
GoabText,
GoabWorkSideMenu,
GoabWorkSideMenuGroup,
GoabWorkSideMenuItem,
} from "@abgov/angular-components";

@Component({
standalone: true,
selector: "abgov-bug3932",
templateUrl: "./bug3932.component.html",
imports: [
GoabBlock,
GoabText,
GoabWorkSideMenu,
GoabWorkSideMenuGroup,
GoabWorkSideMenuItem,
],
})
export class Bug3932Component {}
6 changes: 6 additions & 0 deletions apps/prs/angular/src/routes/bugs/3932/bug3932.route.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bug",
"id": "3932",
"path": "bugs/3932",
"title": "Work Side Menu tooltips"
}
46 changes: 46 additions & 0 deletions apps/prs/angular/src/routes/bugs/bug3323/bug3323.component.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
<goab-text tag="h1" mt="m" mb="s">Fix 3323 - Tooltip with fixed positioning</goab-text>
<goab-text>
CSS anchor positioning support in this browser:
<strong>{{ supportsCssAnchorPositioning ? "Supported" : "Not supported" }}</strong
>.
</goab-text>

<goab-text tag="h2" mt="m" mb="s">Tooltip in callout</goab-text>
<goab-callout emphasis="low">
<goab-tooltip content="This tooltip shoudn't be cut off">
<goab-button type="tertiary" size="compact">Hover me</goab-button>
</goab-tooltip>
</goab-callout>

<goab-text tag="h2" mt="m" mb="s">Tooltip in container</goab-text>
<goab-container>
<goab-tooltip content="This tooltip shoudn't be cut off">
<goab-icon type="information-circle"></goab-icon>
</goab-tooltip>
</goab-container>

<goab-text tag="h2" mt="m" mb="s">Basic tooltip</goab-text>
<goab-tooltip content="Additional information about this item">
<goab-button type="secondary">Hover me</goab-button>
</goab-tooltip>

<goab-text tag="h2" mt="m" mb="s">Horizontal alignment</goab-text>
<goab-grid minChildWidth="60px">
<goab-tooltip content="Left aligned tooltip" hAlign="left">
<goab-icon type="information-circle" />
</goab-tooltip>
<goab-tooltip content="Center aligned tooltip" hAlign="center">
<goab-icon type="information-circle" />
</goab-tooltip>
<goab-tooltip content="Right aligned tooltip" hAlign="right">
<goab-icon type="information-circle" />
</goab-tooltip>
</goab-grid>

<goab-text tag="h2" mt="m" mb="s"> Long Tooltip </goab-text>
<goab-tooltip
content="This is a deliberately long tooltip message that should render at a readable width, wrap naturally, and not collapse into a one-pixel column on first hover."
maxWidth="320px"
>
<goab-button type="tertiary" size="compact"> Long tooltip </goab-button>
</goab-tooltip>
31 changes: 31 additions & 0 deletions apps/prs/angular/src/routes/bugs/bug3323/bug3323.component.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { Component } from "@angular/core";
import {
GoabButton,
GoabCallout,
GoabContainer,
GoabIcon,
GoabTooltip,
GoabText,
GoabGrid,
} from "@abgov/angular-components";

@Component({
standalone: true,
selector: "abgov-bug3323",
templateUrl: "./bug3323.component.html",
imports: [
GoabButton,
GoabCallout,
GoabContainer,
GoabIcon,
GoabTooltip,
GoabText,
GoabGrid,
],
})
export class Bug3323Component {
readonly supportsCssAnchorPositioning =
typeof CSS !== "undefined" &&
typeof CSS.supports === "function" &&
CSS.supports("anchor-name: --goa-tooltip-target");
}
6 changes: 6 additions & 0 deletions apps/prs/angular/src/routes/bugs/bug3323/bug3323.route.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"type": "bug",
"id": "3323",
"path": "bugs/bug3323",
"title": "Tooltip with fixed positioning"
}
Loading
Loading