Fix scheduled date handling in recurring tasks#4144
Open
ashprice wants to merge 2 commits into
Open
Conversation
The "scheduled" attribute of tasks generated by recurring tasks is now updated the same way the "wait" attribute is handled. The difference between the original "scheduled" and "due" dates is added to the "due" date of each generated task when a "scheduled" date is present.
ashprice
changed the title
Signed-off-by: ashprice <gitcommit1@sl.ashprice.co.uk>
Contributor
Author
|
Didn't look at the current state close enough and missed that. Sorry! |
Contributor
Author
|
Not sure of the cause of the failing test. I can't recreate it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subset from PR #3006 without the changes to
until.Closes #2414, #97, #3823, part of #1534.
#1983 is mostly covered by
untilby usinguntil:now+someperiodoruntil:date, the main thing missing there would beuntil:some-task-count. I could probably implement that behaviour, but I think it might be better to wait for iterative tasks to land?