fix: provide default for var.location to improve backwards compatibility of ADC change.#213
fix: provide default for var.location to improve backwards compatibility of ADC change.#213kevcube wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
var.location to improve backwards compatibility of ADC change.#213Conversation
…ility of ADC change. Currently, the logic was to use `var.function_location` if `var.location` was unset. But because `var.location` has no default, this module cannot be used without setting it.
kevcube
requested review from
a team,
ayushmjain,
krprabhat-eng,
prabhu34 and
q2w
as code owners
|
@anshukaira this is related to #194 |
|
Can we somehow mark function_location as deprecated & promote the use of location. If we make location as optional variable, it will show under advanced fields in ADC. As we created a new major version for this breaking change, it should not impact modules consuming the old version. |
For now, i think it should be fine to add this, as this will be release as 0.8.1 i think. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
Not staleOn Apr 14, 2026, at 19:17, github-actions[bot] ***@***.***> wrote:github-actions[bot] left a comment (GoogleCloudPlatform/terraform-google-cloud-functions#213)
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@krprabhat-eng @anshukaira can this merge? |
3 participants
Currently, the logic was to use
var.function_locationifvar.locationwas unset. But becausevar.locationhas no default, thevar.location is unsetscenario is impossible; terraform will ask for it to be set if this is the root module, and will error if this is a child module of the active configuration.ref: terraform-google-modules/terraform-example-foundation#1458