Simplify uap plugin architecture#2316
Open
rafaelwestphal wants to merge 3 commits into
Open
Conversation
rafaelwestphal
force-pushed
the
westphalrafael/simplify-uap-plugin
branch
7 times, most recently
from
2d0eb15 to
7af0d98
Compare
rafaelwestphal
changed the title
rafaelwestphal
force-pushed
the
westphalrafael/simplify-uap-plugin
branch
2 times, most recently
from
39a6bf9 to
a76595d
Compare
…d packaging With Fluent Bit completely gone from Ops Agent 3.0, the google-cloud-ops-agent-wrapper supervisor binary is completely obsolete. We have purged it entirely from the repository: - Deleted cmd/agent_wrapper/ Go package (9 files deleted!). - Deleted builds/agent_wrapper.sh build script. - Removed wrapper build stages and COPY commands from dockerfiles/template and Dockerfile. - Removed wrapper build block from Dockerfile.windows. - Cleared out wrapper binaries from RPM/DEB/Goo package manifests and scripts. TAG=agy BUG=b/517494318 CONV=a3aefa50-102a-4eb8-ac21-894088d8c5df
With Fluent Bit completely removed, there is no longer a need to maintain complex lifecycle synchronization across multiple subagents. We have simplified the cmd/ops_agent_uap_plugin subagent loops to execute OTel collector directly: - Removed sync.WaitGroup and goroutine spawning from runSubagents on both Linux and Windows. - Removed sync.WaitGroup parameters and defer wg.Done() from runSubAgentCommand. - Simplified RunSubAgentCommandFunc type definition to omit the WaitGroup parameter. - Deleted sync package imports from service_linux.go and service_windows.go. - Simplified all UAP plugin linux/windows unit tests to remove WaitGroup declarations and calls. TAG=agy BUG=b/517494318 CONV=a3aefa50-102a-4eb8-ac21-894088d8c5df
… Linux tests TAG=agy
rafaelwestphal
force-pushed
the
westphalrafael/simplify-uap-plugin
branch
from
2677b8c to
b4aed70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With Fluent Bit completely removed, there is no longer a need to maintain complex lifecycle synchronization across multiple subagents. We have simplified the
cmd/ops_agent_uap_pluginsubagent loops to execute OTel collector directly:sync.WaitGroupand goroutine spawning fromrunSubagentson both Linux and Windows.sync.WaitGroupparameters anddefer wg.Done()fromrunSubAgentCommand.RunSubAgentCommandFunctype definition to omit theWaitGroupparameter.syncpackage imports fromservice_linux.goandservice_windows.go.WaitGroupdeclarations and calls.Related issue
b/517494318
How has this been tested?
Checklist: