Adding global config to enable otlp_exporter by rafaelwestphal · Pull Request #2292 · GoogleCloudPlatform/ops-agent

rafaelwestphal · 2026-05-06T18:21:26Z

Description

This PR removed the environment variables mechanism to enable the OTLP exporters, and change it to a global config in the config.yaml

otlp_exporter: true

Related issue

b/513235176

How has this been tested?

Teseted in a VM with the new feature

Checklist:

Unit tests
- Unit tests do not apply.
- Unit tests have been added/modified and passed for this PR.
Integration tests
- Integration tests do not apply.
- Integration tests have been added/modified and passed for this PR.
Documentation
- This PR introduces no user visible changes.
- This PR introduces user visible changes and the corresponding documentation change has been made.
Minor version bump
- This PR introduces no new features.
- This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
- This PR bumps the version.

…oring

TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

This updates the goldens to reflect the deprecation and removal of CastToSum and NormalizeSums processors, replaced by the transform processor in master. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

XuechunHou · 2026-05-20T03:49:56Z

+	for k, v := range enabledExperiments {
+		newExperiments[k] = v
+	}
+	if uc.Global.GetOtlpExporter() {


the global config knob should replace the experimental flag.

We should remove any references to the otlp_exporter experimental flag in the confgenerator. Instead, we should rely on verifying whether the global configuration OtlpExporter is set.

Decoupled the new config knob with any experiment relation. IT should now only use the config

Remove all references to the `otlp_exporter` experimental flag in the confgenerator. Instead, rely on verifying whether the global configuration `OtlpExporter` is set using a dedicated context helper. Also, update tests to use the new ContextWithOtlpExporter helper. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Introduce a shared `internal/ctxkeys` package to store context keys and helpers without introducing circular dependencies between `confgenerator` and `healthchecks`. Update `internal/healthchecks/api_check.go` to rely on `ctxkeys.OtlpExporterFromContext` instead of the deprecated experiments map. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Clean up formatting in the test case input file. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Clean up formatting across multiple test case input files to ensure consistent style without empty lines immediately following section headers. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Remove the newly introduced `internal/ctxkeys` package and move the OtlpExporter context keys and helper functions directly into the existing `internal/experiments` package. This avoids package bloat since `internal/experiments` is already a shared dependency imported by both `confgenerator` and `healthchecks` to manage feature states. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Remove the `ctx` parameter from `HealthCheckRegistryFactory` and all individual diagnostic check functions (`runLoggingCheck`, etc.), reverting them to use `context.Background()` internally as they did in master. Since `otlpExporterEnabled` is now passed explicitly as a boolean parameter, we no longer need the context to carry the configuration state through the health check layer. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Remove redundant ContextWithExperiments calls from confmerger.go, files.go, and self_metrics.go, as these are already handled internally by downstream functions (Validate, GenerateConfigs, ExtractFeatures). Revert ParseExperimentalFeatures in experiments.go to match master styling. These 4 files are now 100% identical to master. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

This updates the goldens to reflect recent master changes that added metric_start_time processor for IIS receiver. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Update `getHealthCheckResults` call in `main_windows.go` to match the new signature (pass `otlpExporterEnabled bool` instead of `ctx`). Update `runHealthChecks` call in `service_windows_test.go` to match the new signature (remove `ctx` and pass `false` for `otlpExporterEnabled`). TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Remove the unused `ctx = uc.ContextWithExperiments(ctx)` call from UAP plugin's `Start` method on Windows, as the `ctx` variable is not referenced anywhere after this line following the health check context refactoring. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

XuechunHou · 2026-05-23T20:34:07Z

+		newExperiments[k] = v
+	}
+	ctx = experiments.ContextWithExperiments(ctx, newExperiments)
+	if uc.Global.GetOtlpExporter() || OtlpExporterFromContext(ctx) {


I think if should only check for uc.Global.GetOtlpExporter() here.

XuechunHou · 2026-05-24T01:11:21Z

Can we implement this without propagating the otlpExporter config setting through context?

Here is a my prototype: https://screenshot.googleplex.com/AamNBzffYZrN3Ln, i.e: After we generate all the OTel pipelines, but before the actual OTel YAML config is generated (link), we replace the Google Cloud exporter with the OTLP exporter."

…version Completely eliminate OTLP exporter configuration propagation through context. Instead, implement a post-processing conversion pass (`ConvertPipelinesToOtlp`) in `GenerateOtelConfig` that runs after all pipelines (including self-metrics) have been generated, but before the final OTel YAML is produced. Details: - Remove `ContextWithOtlpExporter`, `OtlpExporterFromContext`, and `otlpExporterKey` from config.go. - Make old converter wrappers in confgenerator.go (ConvertGCMOtelExporterToOtlpExporter, etc.) dummy no-ops to avoid changing 24+ third-party app files. - Decouple `AgentSelfMetrics` by adding `OtlpExporterEnabled` field directly to the struct. - Decouple feature tracking by passing `UnifiedConfig` to `getOtlpExporterFeatureConfig`. - Update tests to use programmatic configuration updates or post-processing conversion instead of context overrides. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

…nd clean up redundant context wrapping Conclude the merge from master. Resolve the conflict in `confgenerator/config.go` by removing the `ContextWithExperiments` definition and deprecated port constants. Also, completely clean up the redundant `ContextWithExperiments` calls from `main.go`, `run_windows.go`, `confgenerator.go`, `config.go` (Validate), and `feature_tracking.go`. Since the OTLP exporter has been decoupled from experiments, we no longer need this programmatic experiments wrapping context mechanism at all! TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Group imports into standard, third-party, and project-local blocks to satisfy the gci linter rules. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Remove the duplicate empty line at line 74 and re-format/re-group the imports block using golangci-lint run --fix to satisfy the strict gci linter rules. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

XuechunHou · 2026-05-25T23:13:21Z

-	if _, ok := pipeline.ExporterTypes["logs"]; ok {
-		pipeline.ExporterTypes["logs"] = otel.OTLP_Logs
+		if _, ok := pipeline.ExporterTypes["logs"]; ok {
+			if pipeline.ExporterTypes["logs"] == otel.Logging {


i dont think this if clause is necessary here. All Otel logging pipielines use otel.Logging as the exporter.

XuechunHou · 2026-05-25T23:34:23Z

Please make sure all integration tests pass, except for flakes.

rafaelwestphal added 3 commits May 6, 2026 18:12

Initial Implementation of global knob for otlp_exporter

f1bc179

Fix Windows compilation and UAP plugin tests for health checks refact…

149c203

…oring

Merge branch 'master' into westphalrafael/otlp_exporter_config_knob

eeda003

rafaelwestphal marked this pull request as ready for review May 13, 2026 20:59

rafaelwestphal added 2 commits May 13, 2026 16:59

Merge branch 'master' into westphalrafael/otlp_exporter_config_knob

6d204ed

Update goldens for otlp_exporter_global_config after merging master

32a833d

TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

rafaelwestphal changed the title ~~Initial Implementation of global knob for otlp_exporter~~ Adding global config to enable otlp_exporter May 15, 2026

rafaelwestphal added 4 commits May 15, 2026 10:07

Merge branch 'master' into westphalrafael/otlp_exporter_config_knob

9e476c9

Merge branch 'master' into westphalrafael/otlp_exporter_config_knob

0f2ad89

Merge branch 'master' into westphalrafael/otlp_exporter_config_knob

bdd0aa4

Update goldens for otlp_exporter_global_config after merging master

3087f88

This updates the goldens to reflect the deprecation and removal of CastToSum and NormalizeSums processors, replaced by the transform processor in master. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

XuechunHou reviewed May 20, 2026

View reviewed changes

rafaelwestphal added 11 commits May 21, 2026 17:56

Remove extra blank line from test-otlp-exporter-only/input.yaml

c7fb0ed

Clean up formatting in the test case input file. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Remove rogue empty lines from various test input.yaml files

03c1060

Clean up formatting across multiple test case input files to ensure consistent style without empty lines immediately following section headers. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Merge branch 'master' into westphalrafael/otlp_exporter_config_knob

bd5ccef

Update goldens for otlp_exporter_global_config after merging master

a6801d6

This updates the goldens to reflect recent master changes that added metric_start_time processor for IIS receiver. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

XuechunHou reviewed May 23, 2026

View reviewed changes

rafaelwestphal added 4 commits May 25, 2026 15:21

Format imports in config.go to satisfy gci linter

01aac52

Group imports into standard, third-party, and project-local blocks to satisfy the gci linter rules. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

Fix config.go formatting to satisfy golangci-lint (gci)

d9915cd

Remove the duplicate empty line at line 74 and re-format/re-group the imports block using golangci-lint run --fix to satisfy the strict gci linter rules. TAG=agy CONV=60663306-7f95-4fa8-8baa-65483fc3cf16

XuechunHou reviewed May 25, 2026

View reviewed changes

XuechunHou approved these changes May 25, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding global config to enable otlp_exporter#2292

Adding global config to enable otlp_exporter#2292
rafaelwestphal wants to merge 24 commits into
masterfrom
westphalrafael/otlp_exporter_config_knob

rafaelwestphal commented May 6, 2026 •

edited

Loading

Uh oh!

XuechunHou May 20, 2026

Uh oh!

rafaelwestphal May 22, 2026

Uh oh!

XuechunHou May 23, 2026

Uh oh!

XuechunHou commented May 24, 2026

Uh oh!

XuechunHou May 25, 2026

Uh oh!

XuechunHou commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rafaelwestphal commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issue

How has this been tested?

Checklist:

Uh oh!

XuechunHou May 20, 2026

Choose a reason for hiding this comment

Uh oh!

rafaelwestphal May 22, 2026

Choose a reason for hiding this comment

Uh oh!

XuechunHou May 23, 2026

Choose a reason for hiding this comment

Uh oh!

XuechunHou commented May 24, 2026

Uh oh!

XuechunHou May 25, 2026

Choose a reason for hiding this comment

Uh oh!

XuechunHou commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rafaelwestphal commented May 6, 2026 •

edited

Loading