Skip to content

refactor(gae8): Remove unused compiler region tag - #10329

Merged
Kef131 merged 1 commit into
mainfrom
refactor(gae8)_remove_unused_compiler_regiontag
Aug 20, 2026
Merged

refactor(gae8): Remove unused compiler region tag #10329
Kef131 merged 1 commit into
mainfrom
refactor(gae8)_remove_unused_compiler_regiontag

Conversation

@Kef131

@Kef131 Kef131 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/347351402

Remove compiler region tag from appengine-java8/gaeinfo/pom.xml.

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Aug 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the region tags [START compiler] and [END compiler] from the pom.xml file in appengine-java8/gaeinfo and cleans up the formatting of the <properties> element. There are no review comments, and I have no feedback to provide.

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kef131
Kef131 marked this pull request as ready for review August 19, 2026 21:44
@Kef131
Kef131 requested review from a team and yoshi-approver as code owners August 19, 2026 21:44
@snippet-bot

snippet-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Kef131
Kef131 merged commit 79c948a into main Aug 20, 2026
15 checks passed
@Kef131
Kef131 deleted the refactor(gae8)_remove_unused_compiler_regiontag branch August 20, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants