Skip to content

fix(cfg): restore default http1 protocol and disable grpc-by-default optimization - #5155

Merged
dangarhs merged 1 commit into
masterfrom
revert-grpc-default-on
Oct 13, 2026
Merged

dangarhs merged 1 commit into
masterfrom
revert-grpc-default-on

Conversation

@dangarhs

Copy link
Copy Markdown
Contributor

Description

  • Restore default: "http1" for gcs-connection.client-protocol in cfg/params.yaml and disallow empty "" protocol unmarshaling in cfg/types.go.
  • Remove the machine-based-optimization (high-performance / gke-only: true) from gcs-connection.enable-grpc-by-default in cfg/params.yaml and regenerate cfg/config.go and cfg/config_test.go.
  • Restore test assertions in cfg/optimize_test.go, cmd/config_validation_test.go, cmd/datatypes_parsing_test.go, and cmd/root_test.go to match the pre-grpc-default-on baseline.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Verified make build (go generate, go vet, golangci-lint) passes cleanly.
  2. Unit tests - Passed make test across all packages in the repository.
  3. Integration tests - In progress.

Any backward incompatible change? If so, please explain.

No

@dangarhs dangarhs added execute-integration-tests Run only integration tests kokoro:run Testing kokoro run labels Oct 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'gcs-connection.enable-grpc-by-default' optimization rules and associated tests. Additionally, it changes the default value of the 'client-protocol' flag from an empty string to 'http1', updating the corresponding configuration parsing, validation, and tests. I have no feedback to provide as there are no review comments.

@dangarhs
dangarhs marked this pull request as ready for review October 13, 2026 08:49
@dangarhs
dangarhs requested a review from a team as a code owner October 13, 2026 08:49
@github-actions github-actions Bot added the remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR. label Oct 13, 2026
@codecov

codecov Bot commented Oct 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.89%. Comparing base (cdc5693) to head (4f797ec).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5155       +/-   ##
===========================================
+ Coverage        0   84.89%   +84.89%     
===========================================
  Files           0      178      +178     
  Lines           0    19638    +19638     
===========================================
+ Hits            0    16671    +16671     
- Misses          0     2966     +2966     
- Partials        0        1        +1     
Flag Coverage Δ
unittests 84.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread cfg/config.go
@dangarhs
dangarhs merged commit d2d85d0 into master Oct 13, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests kokoro:run Testing kokoro run remind-reviewers Auto remind reviewers in attention set for review post 24hrs of inactivity on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants