Repository navigation
fix(server): send gRPC proxy requests to the session that owns them - #736
Draft
omkargaikwad23 wants to merge 1 commit into
Draft
omkargaikwad23 wants to merge 1 commit into
omkargaikwad23 wants to merge 1 commit into
Conversation
Collaborator
Author
VerificationI ran the same script on
Local tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
GrpcProxyModel.generateused the queues of the first active session (list(PROXY_QUEUES.keys())[0]). With two concurrentInteractsessions, the prompts of the second session went to the client of the first session. The second session then got the answers of that client.How
Interacthandler already puts the session ID into the config.GrpcProxyModelkeeps this ID and uses the queues of that session.RuntimeErrorif its session is not active, or if it has no session ID and two or more sessions are active.Behavior change
A request that the model cannot assign to a session now fails. Before, it went to the first active session.
Testing
grpc_proxy_session_test.py. Onmain, 4 of the 5 tests fail.