Repository navigation
fix(databases): add the database identity to the query cache key - #735
Draft
omkargaikwad23 wants to merge 1 commit into
Draft
omkargaikwad23 wants to merge 1 commit into
omkargaikwad23 wants to merge 1 commit into
Conversation
Collaborator
Author
VerificationI ran the same script on
Local tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The key of the query cache was a hash of the query and the engine URL. For some databases, that value does not identify the database:
postgresql+pg8000://ormysql+pymysql://.mssql+pytds://.Thus the same query on two different databases used one cache entry. The second database got the rows of the first.
How
DB._cache_scope(). It returns the database type, the path (host or instance), the database name, and the user name.Behavior change
The cache key changes for these databases. The cache entries that exist now are not read again.
Testing
query_cache_key_test.py. Onmain, 10 of the 12 test cases fail.