Repository navigation
fix(server): limit the custom classes that the eval server loads - #734
Draft
omkargaikwad23 wants to merge 1 commit into
Draft
omkargaikwad23 wants to merge 1 commit into
omkargaikwad23 wants to merge 1 commit into
Conversation
Collaborator
Author
VerificationI called
Local tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
A model config can set
generator_class, and a database config can setconnector_class. EvalBench imports the class and calls it with the config. On the eval server, the config comes from the client. Thus a client could make the server call any importable class, for examplesubprocess:Popen.How
eval_server.py),load_custom_classloads a class only from the modules inEVALBENCH_CUSTOM_CLASS_MODULES(comma-separated). A module in the list also permits its submodules. The default list is empty.load_custom_classraisesPermissionErrorbefore the import.Behavior change
On the eval server,
generator_classandconnector_classfail unless the server permits the module withEVALBENCH_CUSTOM_CLASS_MODULES.Limits
Testing
class_loader_server_test.py.