Repository navigation
fix(datasets): limit the variables that a dataset can read on the eval server - #733
Draft
omkargaikwad23 wants to merge 1 commit into
Draft
omkargaikwad23 wants to merge 1 commit into
omkargaikwad23 wants to merge 1 commit into
Conversation
Collaborator
Author
VerificationI loaded the same dataset with
The error text in row 1: Local tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
A dataset can contain
${VAR}placeholders, and EvalBench replaces them with values from the environment. On the eval server, the dataset comes from the client, andListEvalInputssends the expanded dataset to the client. Thus a client could read each environment variable of the server.How
eval_server.py), a dataset can read only the variables inEVALBENCH_DATASET_ENV_VARS(comma-separated). The default isEVAL_GCP_PROJECT_ID,EVAL_GCP_PROJECT_REGION,GOOGLE_CLOUD_PROJECT.$VAR) is not expanded.Behavior change
On the eval server, a dataset that reads a variable outside the list now fails. To permit a variable, add it to
EVALBENCH_DATASET_ENV_VARSon the server.Testing
dataset_env_placeholders_test.py.