Repository navigation
fix: keep dataset file names inside their base directory - #732
Draft
omkargaikwad23 wants to merge 1 commit into
Draft
omkargaikwad23 wants to merge 1 commit into
omkargaikwad23 wants to merge 1 commit into
Conversation
Collaborator
Author
VerificationI ran the same script on
Local tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Two places joined a file name from a dataset to a base directory without a check. A name with
../, or an absolute path, pointed outside the directory.env_filesof a containerized case._collect_env_filesread the file on the host and put its content into the case container._materialize_env_fileswrote the file in the container.SQLiteDBmade directories and connected to the path.get_sqlite_ground_truthread the path.How
contained_path(base, name)inutil/safepath.py. It raisesValueErrorifnameis empty, is absolute, or is outsidebaseafter symlinks are resolved. A name in a subdirectory ofbaseis valid._collect_env_filesand_materialize_env_filesskip such a name and write a log line.SQLiteDB._get_connection_pathraisesValueError.ensure_database_existsnow uses this function.get_sqlite_ground_truthreturns an empty list, as for a database file that does not exist.Behavior change
A SQLite database name and an
env_filesname must be relative to their base directory. An absolute name, or a name that leaves the directory with../, is now rejected.Testing
safepath_test.py.