Repository navigation
fix(reporting): remove secret values from the reported config - #731
Draft
omkargaikwad23 wants to merge 1 commit into
Draft
omkargaikwad23 wants to merge 1 commit into
omkargaikwad23 wants to merge 1 commit into
Conversation
Collaborator
Author
VerificationI called
Fake secret values in the report: 4 on Local tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
config_to_dfwrites the run config, the model config, and the database configs toconfigs.csvand to BigQuery. It wrote each value as it was. Thus a password or an API key in a config was in the report. This includes a value that!ENVreads from the environment.How
redact_secretsmakes a copy of the config for the report:[REDACTED]if the last words of the key name a secret:password,passwd,secret,token,credential,credentials,authorization,apikey, orkeyafterapi,private,access, orsecret.scheme://user:password@host.projects/.../secrets/...). That value is a reference, not a secret.The config that the run uses does not change.
Limits
configs.csvfiles, do not change.Testing
config_redaction_test.py.