Skip to content

fix(deps): pin google-adk>=2.14.0 to remediate CVE-2026-4810 - #730

Open
graceqi-g wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
graceqi-g:fix/upgrade-google-adk-cve-2026-4810
Open

graceqi-g wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
graceqi-g:fix/upgrade-google-adk-cve-2026-4810

Conversation

@graceqi-g

Copy link
Copy Markdown
Collaborator

Summary

Remediates CVE-2026-4810 (requires google-adk >= 1.28.1) in EvalBench's locked dependencies and container images.

Root Cause

pyproject.toml listed "google-adk" with no minimum version floor. When Dependabot bumped opentelemetry-api from 1.41.1 to 1.45.1 in 4915eea4 (PR #678), uv silently downgraded google-adk in uv.lock from 2.1.0 back to 1.14.1 because earlier google-adk releases capped opentelemetry-api <= 1.42.1 (and google-adk >= 2.14.0, the first release supporting opentelemetry-api 1.45.2, requires Python >= 3.11).

Changes

  • pyproject.toml & viewer/pyproject.toml:
    • Pin "google-adk>=2.14.0" to remediate CVE-2026-4810 and prevent future transitive dependency bumps from silently downgrading google-adk.
    • Bump requires-python from >=3.10 to >=3.11 (Python 3.10 is EOL, google-adk >= 2.13 requires >=3.11, CI already runs Python 3.11, and the service image runs Python 3.13).
  • uv.lock:
    • Regenerated with uv lock, upgrading google-adk 1.14.1 -> 2.15.0 (and starlette 0.52.1 -> 1.10.0, google-genai 1.75.0 -> 2.34.0, google-cloud-aiplatform 1.133.0 -> 2.10.0, watchdog 6.0.0 -> 7.1.0) while preserving opentelemetry-api 1.45.2, opentelemetry-sdk 1.45.2, and mcp 1.28.1.
  • README.md: Update minimum Python requirement note from 3.10 to 3.11.

Verification

  • uv sync --frozen --all-packages and uv run make proto succeeded.
  • SKIP_CLOUD_TESTS=true pytest evalbench/test -vv: 1,295 passed, 11 skipped, 0 failed.
  • pycodestyle . --config=.pycodestyle: 0 errors.
  • uv build + clean-venv .ci/verify_package.py: 180 modules checked, package is importable.
  • Verified google.adk.sessions.VertexAiSessionService signature and vertexai.agent_engines compatibility.

Dependabot commit 4915eea (bumping opentelemetry-api to 1.45.1) silently downgraded google-adk from 2.1.0 to 1.14.1 in uv.lock because pyproject.toml had no version floor on google-adk and earlier google-adk releases capped opentelemetry-api below 1.45.

- Pin google-adk>=2.14.0 (the first release compatible with opentelemetry-api 1.45.2 and well above the CVE-2026-4810 fix in 1.28.1)
- Bump requires-python to >=3.11 (Python 3.10 reached EOL and google-adk>=2.13 requires >=3.11; CI already runs on 3.11 and Docker on 3.13)
- Regenerate uv.lock, resolving google-adk 1.14.1 -> 2.15.0 (and starlette 0.52.1 -> 1.10.0) while preserving opentelemetry-api 1.45.2 and mcp 1.28.1
Comment thread pyproject.toml
"mongomock",
"rich",
"google-adk",
# Minimum 2.14.0 required to remediate CVE-2026-4810 (>=1.28.1) while

@omkargaikwad23 omkargaikwad23 Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this detail in PR description only as this comment might become stale later?

@omkargaikwad23

Copy link
Copy Markdown
Collaborator

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants