Repository navigation
Conversation
Dependabot commit 4915eea (bumping opentelemetry-api to 1.45.1) silently downgraded google-adk from 2.1.0 to 1.14.1 in uv.lock because pyproject.toml had no version floor on google-adk and earlier google-adk releases capped opentelemetry-api below 1.45. - Pin google-adk>=2.14.0 (the first release compatible with opentelemetry-api 1.45.2 and well above the CVE-2026-4810 fix in 1.28.1) - Bump requires-python to >=3.11 (Python 3.10 reached EOL and google-adk>=2.13 requires >=3.11; CI already runs on 3.11 and Docker on 3.13) - Regenerate uv.lock, resolving google-adk 1.14.1 -> 2.15.0 (and starlette 0.52.1 -> 1.10.0) while preserving opentelemetry-api 1.45.2 and mcp 1.28.1
graceqi-g
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
November 21, 2026 01:46
| "mongomock", | ||
| "rich", | ||
| "google-adk", | ||
| # Minimum 2.14.0 required to remediate CVE-2026-4810 (>=1.28.1) while |
Collaborator
There was a problem hiding this comment.
Should we keep this detail in PR description only as this comment might become stale later?
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates CVE-2026-4810 (requires
google-adk >= 1.28.1) in EvalBench's locked dependencies and container images.Root Cause
pyproject.tomllisted"google-adk"with no minimum version floor. When Dependabot bumpedopentelemetry-apifrom1.41.1to1.45.1in4915eea4(PR #678),uvsilently downgradedgoogle-adkinuv.lockfrom2.1.0back to1.14.1because earliergoogle-adkreleases cappedopentelemetry-api <= 1.42.1(andgoogle-adk >= 2.14.0, the first release supportingopentelemetry-api 1.45.2, requires Python>= 3.11).Changes
pyproject.toml&viewer/pyproject.toml:"google-adk>=2.14.0"to remediate CVE-2026-4810 and prevent future transitive dependency bumps from silently downgradinggoogle-adk.requires-pythonfrom>=3.10to>=3.11(Python 3.10 is EOL,google-adk >= 2.13requires>=3.11, CI already runs Python 3.11, and the service image runs Python 3.13).uv.lock:uv lock, upgradinggoogle-adk1.14.1 -> 2.15.0(andstarlette0.52.1 -> 1.10.0,google-genai1.75.0 -> 2.34.0,google-cloud-aiplatform1.133.0 -> 2.10.0,watchdog6.0.0 -> 7.1.0) while preservingopentelemetry-api 1.45.2,opentelemetry-sdk 1.45.2, andmcp 1.28.1.README.md: Update minimum Python requirement note from 3.10 to 3.11.Verification
uv sync --frozen --all-packagesanduv run make protosucceeded.SKIP_CLOUD_TESTS=true pytest evalbench/test -vv: 1,295 passed, 11 skipped, 0 failed.pycodestyle . --config=.pycodestyle: 0 errors.uv build+ clean-venv.ci/verify_package.py: 180 modules checked, package is importable.google.adk.sessions.VertexAiSessionServicesignature andvertexai.agent_enginescompatibility.