Repository navigation
fix(reporting): skip symlinks and special files in the GCS artifact zip - #721
Merged
Merged
Conversation
The agent under test writes the sandbox directory. Add only regular files to the zip, so that a symlink cannot add a file from outside the sandbox and a FIFO cannot block the reporter.
omkargaikwad23
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
November 20, 2026 07:34
Collaborator
Author
|
/gcbrun |
1 similar comment
Collaborator
Author
|
/gcbrun |
wangauone
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
GcsReporterzips the sandbox directory of an agent run and uploads it. The agent under test writes that directory. The zip step followed symlinks, so a symlink in the sandbox added a file from outside the sandbox to the upload.How
os.walkalready did not enter symlinked directories. The PR makes this explicit (followlinks=False) and adds a test.Limits
Testing
gcs_artifact_test.py: a symlink to a file, a nested symlink, a symlink to a directory, and a FIFO.pytest evalbench/testwithSKIP_CLOUD_TESTS=true: 1266 passed, 11 skipped.