feat(sqlserver): harden collector queries, integrate deep scanner, add TDD test suite, and sanitize error log - #591
Open
timchapman wants to merge 11 commits into
Open
timchapman wants to merge 11 commits into
timchapman wants to merge 11 commits into
Conversation
Adds -useEntraIDAuthentication switch to instanceReview.ps1 and runAssessment.bat. When set, the script validates az CLI and go-sqlcmd are installed, triggers az login if no session exists (MFA fires once), and passes --authentication-method ActiveDirectoryDefault to all 32 sqlcmd calls so the cached Azure CLI token is reused throughout. -collectionUserName / -collectionUserPass are mutually exclusive with -useEntraIDAuthentication and will exit with an error if both are supplied. Existing SQL Auth and Windows Auth paths are unaffected.
… engine inside sqlcmd wrapper to guarantee exactly ONE authentication prompt across all 50+ assessments
…ve cross-platform HW Specs, and explicit manifest mapping
…inkedServersDetail.sql to main version
…d TDD test suite, and sanitize error log - Add 15 new T-SQL collector queries covering performance (CPU, Memory, Waits, IO, Batch), hardware specs, Postgres deep migration blockers, and Azure MI metrics. - Sanitize instanceErrorLog.sql to filter sensitive credentials and failed login patterns. - Add full Tim Chapman author attribution and Apache 2.0 license headers across all SQL and PowerShell scripts. - Remove obsolete dbServerDmvPerfmon.sql. - Add test_sqlserver_collector_seams.py TDD suite to verify headers, sanitization, and query integrity. - Align manifest metadata and fix typo identifiers in instanceReview.ps1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description / Summary:
• Entra ID MFA: Persistent ADO.NET connection engine replacing legacy ODBC helper functions.
• Manifest Collector: Explicit manifest tracking via instanceReview_manifest.ps1 and schema parity.
• Deep Assessment Engine: T-SQL PostgreSQL Deep Compatibility Scanner (tsqlPostgresDeepScanner.sql) and SQL Agent Job analyzer (sqlAgentJobs.sql).
• Hardware & Performance DMVs: DMV wait statistics, CPU/Memory profiles, and storage I/O latency trackers.