fix: include serialization error details#695
Open
KirtiRamchandani wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Comlink catches an error while serializing a return value, the caller only receives
Unserializable return value. That hides the underlying serialization error message that usually explains what could not be cloned or serialized.Root cause
The serialization fallback catch block discarded the caught
errorand always created the same genericTypeError.Solution
Build the fallback
TypeErrormessage from the caught serialization error when it has details, while keeping the existing generic prefix. Added a same-window regression test with a deterministic transfer handler that throws during serialization.Tests
npm run buildnpm run test:typesCHROME_ONLY=1 npm run test:unitnpm run test:nodenpm exec --yes prettier@2.8.3 -- --check src/comlink.ts tests/same_window.comlink.test.jsgit diff --checkFixes #679.