fix(teams): answer a duplicate team name with 409 - #170
Merged
Merged
Conversation
Creating a team with a name that is already taken ended in the controller's generic handler and returned 500. The unique violation on the team name is now answered with 409 and a fixed message. Every other database error keeps the existing 500 response. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/teamsreturned 500 when the requested team name was already taken. It now returns 409 with a fixed message:{ "success": false, "error": "A team with this name already exists.", "message": "A team with this name already exists." }Only the unique violation on the team name is mapped. Every other database error keeps the existing 500 response.
Changes
backend/src/controllers/teams.controller.ts: map the team-name unique violation to 409 increate.backend/src/routes/__tests__/teams-duplicate-name.test.ts: new route tests against Postgres.There is no team update route, so there is no rename path to handle.
Not changed
Tests
Run locally against a database built with
.github/scripts/ci-bootstrap-schema.js: the new file passes 5/5, and the duplicate-name test fails without the controller change. Backendtsc --noEmitis clean.🤖 Generated with Claude Code