Skip to content

Add missing v-for keys #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NetworkInterface merged 2 commits into from
Jun 21, 2026
Merged

Add missing v-for keys #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18bda3a
Add missing v-for keys
Gawdl3y Jun 18, 2026
e907975
Skip merge job on pull requests
travismolick Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ jobs:
merge:
name: "Merge: ${{ matrix.image.name }}"
runs-on: ubuntu-latest
if: github.event_name != 'pull_request'
needs:
- build
strategy:
Expand Down
8 changes: 7 additions & 1 deletion resources/js/Components/App/AppNav.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,13 @@
:aria-hidden="showHamburger && !hamburgerOpen"
>
<ul class="grow flex flex-col sm:max-lg:flex-row gap-2">
<AppNavItem v-for="item of mainMenuItems" :show-text="showHamburger" :tooltip-position v-bind="item" />
<AppNavItem
v-for="item of mainMenuItems"
:key="item.label"
:show-text="showHamburger"
:tooltip-position
v-bind="item"
/>
</ul>

<ul class="flex flex-col sm:max-lg:flex-row gap-1">
Expand Down
1 change: 1 addition & 0 deletions resources/js/Components/App/CrudTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<!-- Entity field columns -->
<Column
v-for="field of fields"
:key="field.key"
:field="String(field.key)"
:header="field.label"
sortable
Expand Down
2 changes: 1 addition & 1 deletion resources/js/Components/Common/SkeletonTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
scroll-height="flex"
:dt="{ paginator: { bottom: { border: { width: 0 } } } }"
>
<Column v-for="col of columns" :header="col">
<Column v-for="col of columns" :key="col" :header="col">
<template #body><Skeleton /></template>
</Column>

Expand Down
Loading