fix: fall back when checkout encoding is unavailable#2733
Closed
Sebastian Thiel (Byron) wants to merge 1 commit into
Closed
fix: fall back when checkout encoding is unavailable#2733Sebastian Thiel (Byron) wants to merge 1 commit into
Sebastian Thiel (Byron) wants to merge 1 commit into
Conversation
Sebastian Thiel (Byron)
force-pushed
the
encoding-fallback
branch
from
July 21, 2026 14:44
4371220 to
c85e3c6
Compare
Sebastian Thiel (Byron)
marked this pull request as ready for review
July 21, 2026 15:10
Sebastian Thiel (Byron)
marked this pull request as draft
July 21, 2026 15:10
Non-bare clones aborted when working-tree-encoding named an encoding that encoding_rs does not provide, such as UTF-32. Match Git's worktree behavior by skipping only the unavailable encoding stage while retaining ident, EOL, and smudge processing. Report the ignored error through checkout outcomes and CLI warnings, default the plumbing option to this fallback, and retain an explicit strict option. Conversions into Git remain strict. Add pipeline and end-to-end clone regressions for both SHA-1 and SHA-256. The reference behavior was verified against Git a23bace963 and originates in Git commit 107642f. Validated with focused crate and clone tests, strict Clippy for the changed plumbing crates, minimal hash builds, and `just check`.
Sebastian Thiel (Byron)
force-pushed
the
encoding-fallback
branch
from
July 21, 2026 16:01
c85e3c6 to
b7a9380
Compare
Member
Author
|
Closed in favor of #2737 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tasks
This section is for Byron only. Models continuing this PR must not add, remove, check, uncheck, rename, or reorder checkboxes here.
Everything below this line was generated by Codex GPT-5.
Created by Codex on behalf of Byron. Byron will review before this is ready to merge.
Summary
working-tree-encodingnames an unavailable encoding: skip only that encoding stage instead of aborting checkout.Fixes #1798.
Git compatibility baseline
The behavior was verified against Git
a23bace963, using the local Git source checkout. Git's handling originates in commit107642fe2661236f48b912480e090799e339c512(convert: add 'working-tree-encoding' attribute).Validation
cargo test -p gix-filter unknown_encodingcargo test -p gix-worktree-state --features sha1,sha256cargo test -p gitoxide-core --features blocking-clientcargo test -p gix --test gix --features blocking-network-client,worktree-mutation clone::blocking_iocargo clippy -p gix-filter --all-targets -- -D warningscargo clippy -p gix-worktree-state --all-targets --features sha1,sha256 -- -D warningsgixchecksjust check