feat: initial building of Arm64 container images - #98
Open
p- wants to merge 2 commits into
Open
Conversation
p-
requested review from
JarLob,
Kwstubbs,
anticomputer,
kevinbackhouse and
sylwia-budzynska
as code owners
July 31, 2026 12:25
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the container build/publish pipeline to support producing and publishing Arm64 images, primarily by parameterizing derived-image base layers and switching builds to docker buildx with a per-architecture build matrix and a final multi-arch manifest publish step.
Changes:
- Parameterize derived container Dockerfiles with a
BASE_IMAGEbuild-arg to allow arch-specific base selection. - Refactor
scripts/build_container_images.shto usedocker buildx build, support multiple tags, and optionally push images. - Split the GitHub Actions workflow into per-arch build+push jobs and a manifest-combining publish job.
Show a summary per file
| File | Description |
|---|---|
| src/seclab_taskflows/containers/sast/Dockerfile | Adds BASE_IMAGE build-arg to build from arch-specific base image. |
| src/seclab_taskflows/containers/network_analysis/Dockerfile | Adds BASE_IMAGE build-arg to build from arch-specific base image. |
| src/seclab_taskflows/containers/malware_analysis/Dockerfile | Adds BASE_IMAGE build-arg to build from arch-specific base image. |
| scripts/build_container_images.sh | Switches to docker buildx build, adds multi-tag/push support, and passes BASE_IMAGE to derived images. |
| .github/workflows/publish-container-images.yml | Builds/pushes per-arch images and then publishes multi-arch manifest lists. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Suppressed comments (1)
scripts/build_container_images.sh:43
docker buildx builddoes not always load the built image into the local Docker image store unless--load(or--push) is specified, depending on the active buildx driver. Since this script is intended for local builds as well as CI, add--loadwhenPUSH!=1to preserve the previousdocker buildbehavior (and to ensure derived images can resolve the locally-built base image).
if [[ "${PUSH}" == "1" ]]; then
args+=(--push)
fi
echo "Building ${image}..."
docker buildx build "${args[@]}" "$@" "${CONTAINERS_DIR}/${context}/"
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
scripts/build_container_images.sh:46
docker buildx buildis invoked without--pushor--load. WhenPUSHis left at its default (0), buildx will typically only populate the build cache and will not load the resulting images into the local Docker engine, breaking local usage of this script compared to the previousdocker build -t ...behavior.
if [[ "${PUSH}" == "1" ]]; then
args+=(--push)
fi
echo "Building ${image}..."
docker buildx build "${args[@]}" "$@" "${CONTAINERS_DIR}/${context}/"
}
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Debian images and relevant exist for Amd64 and Arm64 and tools that are currently downloaded like radare as well)