Merge upstream master into GhentAnalysis/master (0.3 release cycle)#121
Open
JulesVandenbroeck wants to merge 308 commits into
Open
Merge upstream master into GhentAnalysis/master (0.3 release cycle)#121JulesVandenbroeck wants to merge 308 commits into
JulesVandenbroeck wants to merge 308 commits into
Conversation
* update met_phi Calibrator to new format * use npvsGood * add npvsGood to uses as well... * Minor adjustments, apply mask to all inputs. --------- Co-authored-by: Mathis Frahm <mathis.frahm@uni-hamburg.de> Co-authored-by: Marcel R. <github.riga@icloud.com>
* Generalize normalization weight producer. * Add pull warning. * Add per-dataset weight norm. * Update. * Optionally log brs. * Improve combinatoric treatment, fix single br calculation. * Helper to fill weight table. * Minor adjustments before review.
Co-authored-by: Mathis Frahm <mathis.frahm@uni-hamburg.de> Co-authored-by: Marcel Rieger <riga@users.noreply.github.com>
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
…h_master' into conflict-resolution-work
Resolve unresolved merge conflicts in mixins.py (taking upstream version), restore missing GhentAnalysis classes (DatasetsMixin, SelectorStepsMixin, MergeCutflowHistograms, MergeHistogramMixin), fix duplicate law.cfg entry, and clean up F401/F811/E303/F821 flake8 errors across multiple files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR tracks all changes in columnflow/columnflow:master
that are not yet present in
GhentAnalysis/master. It is a documentation-only / dummy PR —its purpose is to give an overview of what an eventual merge from upstream would bring in.
The base branch (
GhentAnalysis/master_merge_from_upstream) is identical toGhentAnalysis/masterat the time of this PR's creation.
Migration Guide — Required Changes for Existing Analyses
The following changes are required in any existing analysis to run with the updated columnflow after this PR. All other changes listed above are additive and backwards-compatible.
1. Update
patch_bundle_repo_exclude_filesincolumnflow_patches.pyWhy it breaks:
BundleRepo.exclude_filesnow stores absolute paths (built internally via_cf_path()/_repo_path()helpers) instead of relative paths. The old patch re-prefixed every existing entry with the relative path from the analysis base to the CF base — this now produces invalid doubled paths and breaks remote job bundling.Replace the old function body:
with:
The standard exclusions (
tests,data,.setups,.data,.github, etc.) are now included for both the CF repo and the analysis repo by default. Only append paths that are specific to your analysis and not already covered. Also removeimport osat the top ofcolumnflow_patches.pyif it is no longer used elsewhere.2. Add
**kwargsto all TAF hook function signaturesWhy it breaks: The framework now passes keyword arguments when invoking TAF hook functions. Any hook function without
**kwargsthat callssuper()— or is used as a base viabases=— will raise aTypeError.Apply to all
@my_taf.init,@my_taf.requires,@my_taf.setup, and@my_taf.teardownfunctions across calibrators, selectors, and producers.3. Call
super()in TAF hooks when usingbases=Why it breaks: If an analysis TAF uses
bases=(some_base_taf,)and defines its own hook functions, it must explicitly call the base TAF's hook at the start of each overridden hook. Without the call, the base TAF's initialization, requirement registration, and setup logic (e.g. external file loading, normalization weight table building) is silently skipped.This applies to calibrators, selectors, and producers that extend a built-in columnflow TAF via
bases=.4. Small changes
rucio_report_accessboolean should be added tolaw.cfgfor all fsNew Features
Framework & Core
Producers & Calibrators
Selectors & Categorization
Histogramming & Plotting
Inference / Datacards
Tasks & Infrastructure
Bug Fixes
Histograms & Plots
MergeHistogramsPlotShiftedVariablesPerShift1Dfill_histfunction (bug fix in fill_hist function columnflow/columnflow#768)flat_np_viewfor value assignment (Avoid using flat_np_view for value assignment. columnflow/columnflow#759)CreateDatacardsProducers & Calibrators
super()calls in all task array functionsbtag_wp_weightsproducer: clamp pt and eta efficiency map axesExternalFiledataclass: dropNonevaluessorted_ak_to_roothelper for nested arraysrnd_genargumentnon_zero_maskinmurf_envelope(fix handling of non_zero_mask in murf_envelope columnflow/columnflow#704)Tasks & Workflow
task_namespaceof Wrapper tasksProduceColumnsWrapper; fix brace expansionMergeReductionStatsMergeReducedEventsandMergeSelectionStatsIO & Environment
cf_inspect/ after coffea update (Fix cf_inspect script after coffea update. columnflow/columnflow#753)BundleExternalFilestaskSmall Changes
Dependency & Submodule Updates
law,order,scinum, andboost-histogramsubmodule/version updatesCode Quality & Cleanup
cf_inspect; optimizeUniteColumnsROOT compressioncf_remove_tmp; add local directory check__version__filemake_jme_keysLogging & Verbosity
FlowStrategy.moveCheckCATUpdatestask; add URL to logDocumentation
Tests
This PR was auto-generated to track upstream changes. It is not intended to be merged directly.