fix(llc): call accept race fix by Brazol · Pull Request #1258 · GetStream/stream-video-flutter

Brazol · 2026-06-15T11:24:27Z

Fixes #1254

Summary by CodeRabbit

Bug Fixes
- Fixed an issue where incoming calls could be incorrectly rejected after acceptance due to event timing between WebSocket and HTTP.
- Improved call acceptance handling by updating call acceptance status optimistically and reverting it if server acceptance fails.
New Features
- Incoming call acceptance now reflects immediately in the UI while the server sync completes in the background.
Tests
- Added coverage for optimistic acceptance, rollback on failure, idempotency, and lifecycle acceptance behavior.
Chores
- Updated the changelog with an Unreleased Fixed entry.

coderabbitai · 2026-06-15T11:24:41Z

Warning

Review limit reached

@Brazol, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 9 minutes and 4 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b1aa480b-b1df-4d45-a88b-f1c34648db83

📥 Commits

Reviewing files that changed from the base of the PR and between 6272a75 and df2ccb5.

📒 Files selected for processing (2)

packages/stream_video/CHANGELOG.md
packages/stream_video/lib/src/call/state/mixins/state_lifecycle_mixin.dart

📝 Walkthrough

Walkthrough

lifecycleCallAccepted now accepts an accepted flag, and accept() applies the accepted state before awaiting the coordinator response, reverting it on failure. Tests cover the optimistic state change, rollback, retry, and lifecycle transition cases.

Optimistic call acceptance

Layer / File(s)	Summary
lifecycleCallAccepted accepts a flag `packages/stream_video/lib/src/call/state/mixins/state_lifecycle_mixin.dart`	`lifecycleCallAccepted` accepts `accepted: false` and updates `acceptedByMe` from that value.
Optimistic accept with revert `packages/stream_video/lib/src/call/call.dart`	`accept()` updates local call state before `CoordinatorClient.acceptCall()` and reverts on failure.
Accept flow tests and changelog `packages/stream_video/test/src/call/call_accept_test.dart`, `packages/stream_video/CHANGELOG.md`	Tests cover optimistic acceptance, failure rollback, retry behavior, and lifecycle transition handling; the changelog adds the unreleased fixed note.

Sequence Diagram(s)

sequenceDiagram
  participant UI as UI
  participant Call as Call.accept()
  participant State as lifecycleCallAccepted
  participant Coord as CoordinatorClient
  participant WS as Coordinator event handling

  UI->>Call: accept()
  Call->>State: lifecycleCallAccepted()
  Call->>Coord: acceptCall(cid)
  Note over WS: call.accepted event may arrive while HTTP is in flight
  WS->>State: read acceptedByMe=true
  alt coordinator success
    Coord-->>Call: Success
  else coordinator failure
    Coord-->>Call: Failure
    Call->>State: lifecycleCallAccepted(accepted: false)
  end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped to accept before the wind could race,
And set the little flag in its proper place.
If the server stumbles, I hop back neat,
With false to undo the prior treat!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only links issue `#1254` and omits the required Goal, Implementation details, Testing, and checklist sections.	Add the template sections with a clear goal, implementation summary, testing notes, and checklist items.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly points to the accept() race-condition fix and matches the main code change.
Linked Issues check	✅ Passed	The code updates call.accept() and lifecycleCallAccepted() to prevent the race condition described in issue `#1254`.
Out of Scope Changes check	✅ Passed	The changelog and new tests support the bug fix and do not introduce unrelated scope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/call-accept-race

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/stream_video/lib/src/call/call.dart`:
- Around line 906-909: The unconditional rollback on any Failure at line 906 is
too broad and can cause false rejection states. When a transport-level failure
occurs after the server has accepted the call, reverting acceptedByMe to false
via _stateManager.lifecycleCallAccepted(accepted: false) at line 908 can cause
_handleCoordinatorCallAccepted to incorrectly trigger the "accepted on another
device" logic again. Instead of reverting on all Failure results, classify the
error to distinguish between definitive rejections from the server versus
transport-level failures, and only perform the rollback for specific error types
that represent clear non-acceptance outcomes. This ensures that optimistic
acceptance is only reverted when we have definitive evidence the server did not
accept the call.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2769b017-d45a-48f6-a079-4198e58ef51b

📥 Commits

Reviewing files that changed from the base of the PR and between 879ee25 and 776d71c.

📒 Files selected for processing (2)

packages/stream_video/lib/src/call/call.dart
packages/stream_video/lib/src/call/state/mixins/state_lifecycle_mixin.dart

codecov · 2026-06-15T11:32:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 9.71%. Comparing base (dafe91c) to head (df2ccb5).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #1258   +/-   ##
=====================================
  Coverage   9.71%   9.71%           
=====================================
  Files        676     676           
  Lines      49695   49696    +1     
=====================================
+ Hits        4826    4828    +2     
+ Misses     44869   44868    -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

xsahil03x · 2026-06-24T11:30:33Z

    }
    state = state.copyWith(
-      status: CallStatus.incoming(acceptedByMe: true),
+      status: CallStatus.incoming(acceptedByMe: accepted),


Suggested change

status: CallStatus.incoming(acceptedByMe: accepted),

status: CallStatus.incoming(acceptedByMe: true),

I think its always going to be true

call accept race fix

776d71c

Brazol requested a review from a team as a code owner June 15, 2026 11:24

coderabbitai Bot reviewed Jun 15, 2026

View reviewed changes

Comment thread packages/stream_video/lib/src/call/call.dart

Brazol added 3 commits June 24, 2026 09:08

changelog + tests

6272a75

Merge branch 'main' into fix/call-accept-race

fbba7b9

Merge branch 'main' into fix/call-accept-race

df2ccb5

xsahil03x reviewed Jun 24, 2026

View reviewed changes

xsahil03x approved these changes Jun 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(llc): call accept race fix#1258

fix(llc): call accept race fix#1258
Brazol wants to merge 4 commits into
mainfrom
fix/call-accept-race

Brazol commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

Review limit reached

Walkthrough

Sequence Diagram(s)

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

codecov Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

xsahil03x Jun 24, 2026

Uh oh!

xsahil03x Jun 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	status: CallStatus.incoming(acceptedByMe: accepted),
	status: CallStatus.incoming(acceptedByMe: true),

Uh oh!

Conversation

Brazol commented Jun 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Walkthrough

Sequence Diagram(s)

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

xsahil03x Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

xsahil03x Jun 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Brazol commented Jun 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 15, 2026 •

edited

Loading

codecov Bot commented Jun 15, 2026 •

edited

Loading