Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/sample-distribution.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,22 @@ jobs:
- name: Setup Android SDK
uses: amyu/setup-android@v5

# AGP 8.12 (RN 0.86) does not auto provision the API 37 platform and the
# auto-detected install can land under a name Gradle's `android-37` lookup
# misses. Install it explicitly into the SDK root Gradle resolves from
# (ANDROID_SDK_ROOT/ANDROID_HOME since there is no local.properties here),
# otherwise every RN module fails with:
# "Failed to find target with hash string 'android-37'".
- name: Ensure Android 37 SDK platform & build-tools
run: |
set -e
SDK_ROOT="${ANDROID_SDK_ROOT:-${ANDROID_HOME:-$HOME/.android/sdk}}"
SDKMANAGER="$(command -v sdkmanager || echo "$SDK_ROOT/cmdline-tools/latest/bin/sdkmanager")"
echo "sdkmanager=$SDKMANAGER SDK_ROOT=$SDK_ROOT"
yes | "$SDKMANAGER" --sdk_root="$SDK_ROOT" --licenses >/dev/null 2>&1 || true
"$SDKMANAGER" --sdk_root="$SDK_ROOT" "platforms;android-37" "build-tools;37.0.0"
ls "$SDK_ROOT/platforms"

- uses: ./.github/actions/ruby-cache
- name: Install && Build - SDK and Sample App
uses: ./.github/actions/install-and-build-sdk
Expand Down
6 changes: 3 additions & 3 deletions examples/SampleApp/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import org.apache.tools.ant.taskdefs.condition.Os

buildscript {
ext {
buildToolsVersion = "36.0.0"
buildToolsVersion = "37.0.0"
minSdkVersion = 24
compileSdkVersion = 36
targetSdkVersion = 36
compileSdkVersion = 37
targetSdkVersion = 37
ndkVersion = "27.1.12297006"
kotlinVersion = "2.1.20"
androidXCore = "1.0.2"
Expand Down
7 changes: 7 additions & 0 deletions examples/SampleApp/android/gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,10 @@ edgeToEdgeEnabled=true
# disables the check for multiple instances for gesture handler
# this is needed for react-native-gesture-handler to be both a devDep of core and be a dep on the expo sample app
disableMultipleInstancesCheck=true

# We compile against Android SDK 37, but RN 0.86 pins Android Gradle Plugin
# 8.12.0, which is only validated up to compileSdk 36. The first AGP that
# supports 37 is 9.2+, and moving RN 0.86 onto AGP 9 (a breaking major) is not
# viable yet — so we use AGP's official escape hatch for "compileSdk newer than
# the tested AGP" instead of downgrading. Remove once RN ships an AGP-9 release.
android.suppressUnsupportedCompileSdk=37
Loading