Export the plugin door only behind the dropped-in feature - #15
Closed
MattJackson wants to merge 1 commit into
Closed
MattJackson wants to merge 1 commit into
MattJackson wants to merge 1 commit into
Conversation
Contributor
Author
|
Closed as superseded (ARCHITECT ruling 2026-10-03): #17 (lane-store-cold-boot) set the door exports for the busbar the pin boots. Note: gating export_door! behind dropped-in is not on dev. It comes back with the repin past busbar #433/#442. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C entry symbol
busbar_plugin_dooris now exported only by the dropped-in cdylib build, never by an rlib a busbar build links as a compiled-in row (spec Part 2 #2, compiled-in = dropped-in, one table).export_door!sat unconditionally in this plugin crate, whose crate-type includes rlib; linking two such crates (or one beside its own cdylib) into one binary defines the symbol twice underlto = "fat".dropped-in = []feature on the -plugin crate;export_door!is#[cfg(feature = "dropped-in")], the same shape as busbar-transport-ws.dropped-inon, socargo teststill builds the cdylib the conformance test opens.--features dropped-in(busbar plugin-release.yml/plugin-ci.yml build-p $CRATEand need to pass it).