Repository navigation
door-root: the crate's only public item is door; declares ride the Statement - #24
Draft
MattJackson wants to merge 9 commits into
Draft
MattJackson wants to merge 9 commits into
MattJackson wants to merge 9 commits into
Conversation
…ne selects it); the refusal texts are said to be new in 1.6.0; the plugin owns BUSBAR-4013 and BUSBAR-7087
… is a private module's door, MACRO_DOOR stays inside; tests take the door through LoadedDoor
…only link rows); Cargo.lock held to busbar's at the pin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Door-root recipe steps 1-6 for this repo: the logic crate's only public item is
door; the wholedeclaresdocument rides the Statement's extensions underEXT_DECLARES.Pin: the manifests,
.busbar-refand Cargo.lock stay at dev's busbar pin08d4d7c501, as the migrate PR had them.statement_extensions!/EXT_DECLAREScome from busbar #1399 (not at this pin; #1474 stacks on it), so CI is red until it and #1478 are at the pin; dev's pin is not moved here.Third-party dependency rows and
deny.tomlare dev's: the third-party sync is not this PR's.Earlier row-159 changes carried on this branch
LOCKSTEP with GetBusbar/busbar#1433, which pins this head and removes
BUSBAR-4013andBUSBAR-7087from busbar's kernel catalogue. The two land together. Safe order: busbar #1202 (and the contract it carries) first, then this PR, then busbar#1433. This plugin is the only code that raises 4013 and 7087 (instance.rsnote_line), and no busbar crate raises them, so the plugin owns them and keeps them indeclares.json. Until #1433 lands, busbar's kernel catalogue also holds both codes, so a dropped-in build of this head refuses the boot ("the catalogue already holds that code"). Do not ship it dropped in ahead of #1433.query-keystyle: its declaration, settings, scheme arm,Note::Queryand tests. It was never selected in production. 1.5.5 never presented a credential as a query parameter: v1.5.5crates/busbar/src/egress_auth/mod.rs:182sends gemini's key inx-goog-api-key. The spec only permits a query-key style ("an outbound style may name a query key", BUSBAR-1.6.0.md l.863) and selects none, and no busbar crate or plane names it. Part 1 (l.1934): a capability that is never constructed does not ship.style.rsrefusal doc: it now says the refusal texts are new in 1.6.0, not 1.5.5's words. 1.5.5 refused a credential only for oauth-client-credentials and jwt-bearer (v1.5.5crates/busbar/src/config_validate/mod.rs:516,:543). The diag comments now name the codes and cite the 1.5.5 lines, not 1.5.5 catalogue names, because 1.5.5 had no diagnostic codes.Confirming review: opus (fresh), PASS.
Lands with busbar #1490 / FINAL-REPIN (busbar's link rows name the old entry points until then).