Feature/publish data collection

[mwallschlaeger]

No description provided.

[gemini-code-assist]

Code Review

This pull request introduces support for tabular datasets and tabular collections in the GeoNode MapStore client by adding new routes, components, and plugins (such as TabularPreview, TabularCollectionViewer, ApproveDataCollection, PublishDataCollection, and Footer), and integrating DataCite publishing configurations. It also refactors the card grid container layout to use CSS container queries instead of react-resize-detector. The review feedback highlights several critical areas for improvement, primarily focusing on preventing potential TypeError and AttributeError crashes through optional chaining and safety guards when handling potentially null or undefined resources, layers, or user objects. Additionally, the feedback points out a test suite failure caused by commented-out configuration items, recommends replacing HTML 'class' attributes with React's 'className' in the new Footer component, suggests URL query parameter handling improvements in ShareEmbedLink, and advises cleaning up unused props and speculative comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[gemini-code-assist]

If resource is null or undefined, accessing resource.subtype will throw a TypeError. Please use optional chaining to safely access subtype.

Suggested change

	if (!resource.subtype || !geoserverUrl) {
	if (!resource?.subtype || !geoserverUrl) {

[gemini-code-assist]

If data is undefined, or data.features is empty, or feature.properties is undefined, both headerFromFeatures and rowsFromFeatures will throw a TypeError when calling Object.keys(properties). Please add safety guards and default values to prevent these crashes.

Suggested change

	function headerFromFeatures(data) {
	const feature = data.features[0] || []
	const properties = feature.properties;
	return Object.keys(properties).map((p, index) => ({ value: p, key: propertyToKey(p, index) }));
	};
	function rowsFromFeatures(data) {
	const features = data.features || []
	// [{col1: "value"}]
	return features.map((feature, index) => {
	const row = {}
	const properties = feature.properties
	Object.keys(properties)
	.forEach(name => Object.assign(row, { [propertyToKey(name, index)]: properties[name] }))
	return row;
	});
	};
	function headerFromFeatures(data) {
	const feature = data?.features?.[0];
	const properties = feature?.properties || {};
	return Object.keys(properties).map((p, index) => ({ value: p, key: propertyToKey(p, index) }));
	};
	function rowsFromFeatures(data) {
	const features = data?.features || [];
	// [{col1: "value"}]
	return features.map((feature, index) => {
	const row = {};
	const properties = feature?.properties || {};
	Object.keys(properties)
	.forEach(name => Object.assign(row, { [propertyToKey(name, index)]: properties[name] }));
	return row;
	});
	};

[gemini-code-assist]

If onEdit is not provided (which is possible since value conditionally checks onEdit ? textValue : title), typing in the input will throw a TypeError: onEdit is not a function because it is called unconditionally in onChange. Please add a guard check before calling onEdit.

                    setTextValue(evt.target.value);
                    if (onEdit) {
                        onEdit(evt.target.value);
                    }
                }}
                value={onEdit ? textValue : title}

[gemini-code-assist]

If wmsUrl is undefined, calling wmsUrl.includes('/geoserver/') will throw a TypeError. Please add a check to ensure wmsUrl is defined before calling includes.

Suggested change

	...(sourcetype === SOURCE_TYPES.REMOTE && !wmsUrl.includes('/geoserver/') && {
	serverType: ServerTypes.NO_VENDOR
	})
	...(sourcetype === SOURCE_TYPES.REMOTE && wmsUrl && !wmsUrl.includes('/geoserver/') && {
	serverType: ServerTypes.NO_VENDOR
	})

[gemini-code-assist]

If props.resourceData is null or undefined, destructuring title and owner will throw a TypeError. Additionally, owner.pk on line 44 can crash if owner is null. Please add a safety guard to return null if resourceData is not available, and use optional chaining for owner?.pk.

Suggested change

	const ApproveDataCollectionComponent = (props) => {
	const { open, onClose, style=DEFAULT_DIALOG_STYLE, closeGlyph, dispatch } = props;
	const { title, owner } = props.resourceData;
	const ApproveDataCollectionComponent = (props) => {
	const { open, onClose, style=DEFAULT_DIALOG_STYLE, closeGlyph, dispatch } = props;
	if (!props.resourceData) {
	return null;
	}
	const { title, owner } = props.resourceData;

[gemini-code-assist]

The Cards component no longer accepts or uses the containerWidth prop. You should remove containerWidth={width} from the <Cards /> component. Additionally, since width is no longer used anywhere else in FeaturedList, you can remove the width prop and the withResizeDetector wrapper from FeaturedList entirely to clean up the code.

Suggested change

	<Cards
	featured
	resources={resources}
	formatHref={formatHref}
	isCardActive={isCardActive}
	buildHrefByTemplate={buildHrefByTemplate}
	containerWidth={width}
	downloading={downloading}
	getDetailHref={getDetailHref}
	/>
	<Cards
	featured
	resources={resources}
	formatHref={formatHref}
	isCardActive={isCardActive}
	buildHrefByTemplate={buildHrefByTemplate}
	downloading={downloading}
	getDetailHref={getDetailHref}
	/>

[gemini-code-assist]

Using Array.isArray is safer and standard, as it does not rely on any external imports (like lodash's isArray) and avoids potential ReferenceError if the import is missing.

Suggested change

	if (isArray(pluginsConfig)) {
	if (Array.isArray(pluginsConfig)) {

[gemini-code-assist]

In React, you must use className instead of class for styling elements. Using class will trigger console warnings and may prevent styles from being applied correctly. Please replace all occurrences of class with className in this file.

                    <nav className="col-6 col-md-6 col-lg-3" aria-label="Quick Links">
                        <h3 className="fs-5 fw-bold mb-3 text-light">Quick Links</h3>
                        <ul className="list-unstyled fs-6 fw-normal m-0">
                            <li className="mb-2">
                                <a href="/about" className="link-light text-decoration-none">About</a>
                            </li>
                            <li className="mb-2">
                                <a href="/upload" className="link-light text-decoration-none">Upload</a>
                            </li>
                            <li className="mb-2">
                                <a href="/ogc_and_api" className="link-light text-decoration-none">OGC Services and API</a>
                            </li>
                            <li className="mb-2">
                                <a href="https://www.zalf.de/en/struktur/cdp/fdm/Pages/default.aspx" className="link-light text-decoration-none">Research Data Management</a>
                            </li>
                        </ul>
                    </nav>




                    {/* Resources */}
                    <nav className="col-6 col-md-6 col-lg-3" aria-label="Resources">
                        <h3 className="fs-5 fw-bold mb-3 text-light">Resources</h3>
                        <ul className="list-unstyled fs-6 fw-normal m-0">
                            <li className="mb-2">
                                <a href="/publications" className="link-light">Publications</a>
                            </li>
                            <li className="mb-2">
                                <a href="/data_policy" className="link-light">Data Policy</a>
                            </li>
                            <li className="mb-2">
                                <a href="/how_to_cite" className="link-light">How to Cite Us</a>
                            </li>
                            <li className="mb-2">
                                <a href="/imprint" className="link-light">Imprint</a>
                            </li>
                            <li className="mb-2">
                                <a href="/privacy" className="link-light">Privacy</a>
                            </li>
                        </ul>
                    </nav>

[gemini-code-assist]

Please remove the speculative comment // obsolete by above line?! to keep the codebase clean and maintainable.

Suggested change

	&& resource.subtype !== "tabular" // obsolete by above line?!
	&& resource.subtype !== "tabular"

[gemini-code-assist]

To prevent potential AttributeError crashes (e.g., in environments or tests where the custom user model or monkey-patching is not fully loaded), please check if the can_publish_data_collection attribute exists on the user object before calling it.

Suggested change

	can_publish = user.can_publish_data_collection()
	can_publish = hasattr(user, "can_publish_data_collection") and user.can_publish_data_collection()