fix(agents): keep Claude Bridge continuation wakes out of chat - #1706
Merged
Merged
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (6)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current verification update —
85be8b30The two candidate-introduced CI failures were reproduced with
TMPDIRandPI_CODING_AGENT_DIRabsent, then fixed by making the test fixtures self-contained. Only the two test files changed; production, workflow and assertions are unchanged.review-7f2503525c51ec58approved and acknowledged; earlier clean-range review remains recorded below.85be8b30must pass before merge. The maintainer has explicitly authorized merge after those checks; no auto-merge or bypass is enabled.Earlier failed local runs and the stopped isolation-incident verification below are historical evidence, not the current offline result. The earlier LIVE cleanup limitation remains unchanged.
Linked issue
Refs #1528
Follow-up to the lifecycle-preserving continuation introduced in #1631. This is a nonclosing reference to the approved issue.
PR type
Bug fix (
type:bug).Summary
Changes
extensions/gentle-agents.tstests/gentle-agents.test.tstests/bridge-wake-lifecycle.test.tstests/bridge-wake-rendering.test.tsdocs/gentle-shell.mdodd/tasks/bridge-only-agent-wake.mdThe branch starts at
ac6715933287490307146fcc2131ceaea3374141and contains only03961d42and8f0cfea2, patch-equivalent to the two previously reviewed Bridge commits. Installer work from #1703 and experimental harness commits are excluded. Review scope: six files, 481 additions and 29 deletions (510 authored lines).Test plan
node --experimental-strip-types --test tests/gentle-agents.test.ts tests/bridge-wake-rendering.test.ts tests/bridge-wake-lifecycle.test.ts— 192 passed, zero skipped, in an isolated environment.node scripts/check-types.mjs— 186 recorded diagnostics, no regressions; this is not a zero-diagnostic result.git diff --checkagainst the base; replay patch IDs match the originals.review-8ae84526bbb0fec9). Informational findings remain nonblocking follow-ups.node scripts/run-test-suite.mjs— 4,612 passed, 3 failed, 44 skipped; provider-contract and runtime-harness stages passed. Failures:agent-home.test.ts:31,review-host-relay-routing.test.ts:405, and:1317. The first is explained by the test invocation'sGENTLE_PI_CONFIG_HOMEoverride; the other two causes remain unverified.Manual trial
From a disposable project directory, start a fresh process using the path to this branch's checkout:
This uses the existing Pi agent directory and installed Bridge/authentication. It is not an isolated automated trial: normal session persistence, configured Claude Code hooks/plugins, and provider usage apply. The linked launcher does not rewrite Pi
settings.jsonor auto-provision packages.Select a
claude-bridgemodel, request a background subagent task lasting a few seconds, and let the parent become idle. Verify that the parent continues automatically with the result and no synthetic wake message appears in the visible chat. No experimental harness is needed. This manual trial has not been run by the agent on this checkout.Notes
The maintainer has now explicitly authorized merge after the CI correction and successful checks. The PR remains draft while the new CI run is pending; no admin bypass or auto-merge is enabled.