Skip to content

fix(ask): show the custom response text in the ask_user_choice transcript #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jals1212 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ask): show the custom response text in the ask_user_choice transcript #1695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion extensions/ask-user-choice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,9 @@ export default function askUserChoice(pi: ExtensionAPI): void {
if (details?.selection) {
return new Text(theme.fg("success", `✓ ${details.selection.index}. ${details.selection.label}`), 0, 0);
}
if (details?.customResponse !== undefined) return new Text(theme.fg("success", "✓ Custom response"), 0, 0);
if (details?.customResponse !== undefined) {
return new Text(theme.fg("success", `✓ Custom response — ${details.customResponse}`), 0, 0);
}
return new Text(theme.fg("warning", "Cancelled"), 0, 0);
},
});
Expand Down
14 changes: 14 additions & 0 deletions tests/ask-user-choice.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,3 +711,17 @@ test("ask_user_choice is offered on an interactive rpc host and withdrawn once t
for (const hook of registration.hooks) await hook({}, { mode: "rpc" });
assert.deepEqual(registration.activeTools(), ["read"]);
});

test("ask_user_choice transcript shows the custom response text the user typed", () => {
const { tool } = registerChoiceTool();
const renderResult = (tool as unknown as {
renderResult: (result: unknown, options: unknown, theme: ChoiceTheme) => { render(width: number): string[] };
}).renderResult;
const theme: ChoiceTheme = { fg: (_color, text) => text, bg: (_color, text) => text, bold: (text) => text };
const rendered = renderResult(
{ content: [], details: { question: "Explain?", options, customResponse: "use the staging bucket" } },
{},
theme,
).render(100).join("\n");
assert.equal(stripTerminalSequences(rendered).trimEnd(), "✓ Custom response — use the staging bucket");
});