fix(cloud): constant-time credential comparisons (#350)#399
Open
rudi193-cmd wants to merge 1 commit into
Open
Conversation
…ng#350) Replace plain string equality on bearer and dashboard admin tokens with hmac.Equal so comparisons do not short-circuit on the first differing byte. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
==bearer/admin token checks withhmac.Equalininternal/cloud/auth/auth.goand three sites ininternal/cloud/cloudserver/cloudserver.go.Test plan
go test ./internal/cloud/auth/... ./internal/cloud/cloudserver/...(existing tests; no behavior change for valid/invalid tokens)Fixes #350
Made with Cursor