Add Lotus 1-2-3 type support#548
Open
fhwvtqdc2q-svg wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR extends ugrep’s --file-type type table with Lotus 1-2-3 file extensions and updates config-loading failure output to include an additional workspace-version-related message.
Changes:
- Added
lotus/Lotusfile-type entries with Lotus 1-2-3 extensions and a magic-bytes signature for the capitalized variant. - Added new
std::cerrerror lines inload_config()when config parsing fails or when a config file cannot be read.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { "lex", "l,ll,lmm,lpp,lxx", NULL, NULL }, | ||
| { "lisp", "lisp,lsp", NULL, NULL }, | ||
| { "lotus", "wk1,wk2,wk3,wk4,wks,123", NULL, NULL }, | ||
| { "Lotus", "wk1,wk2,wk3,wk4,wks", NULL, "\\x00\\x00\\x02\\x00|\\x00\\x00\\x1a\\x00|\\x00\\x00\\x04\\x00" }, |
Comment on lines
5010
to
+5014
| if (errors) | ||
| { | ||
| std::cerr << "ugrep: Failed to resolve workspace version in " << config_file << '\n'; | ||
| exit(EXIT_ERROR); | ||
| } |
Comment on lines
+5018
to
5019
| std::cerr << "ugrep: Failed to resolve workspace version: cannot read " << flag_config << '\n'; | ||
| error("option --config: cannot read", flag_config); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Lotus 1-2-3 file-type entries and surfaces the requested workspace-version error message in config loading.\n\nCo-authored-by: Copilot 223556219+Copilot@users.noreply.github.com