Add categorical colorbars for plot and plot3d gallery examples #1259

Activity

1. michaelgrund

   added

   bugSomething isn't workingSomething isn't working

   on May 5, 2021
2. seisman commented on May 5, 2021

   

   seisman

   on May 5, 2021

   Member

   More actions

   The generated CPTs are different. I think there were some CPT-related changes in upstream GMT. The one generated by GMT 6.2.0rc1 makes more sense to me.

   GMT 6.1.1:

   $ gmt makecpt -Cinferno -T0/3/1 -F+c
   0	50.998/10/94.499	L
   1	187/54.5/84.5	L
   2	251.5/181/25.002	B
   B	black
   F	white
   N	127.5
   

   GMT 6.2.0rc1:

   $ gmt makecpt -Cinferno -T0/3/1 -F+c
   0	32.75/12/73.75	L
   1	137.25/34/106	L
   2	227.37/89.375/50.25	L
   3	249/201.25/50.375	B
   N	128
   
3. maxrjones commented on May 5, 2021

   

   maxrjones

   on May 5, 2021

   Member

   More actions

   Yes, the previous CPT range was considered a bug that was fixed in this PR: GenericMappingTools/gmt#4446. I think we should update the series settings for makecpt accordingly in the examples.

   👍React with 👍1Reacted by Michael Grund
4. seisman commented on May 5, 2021

   

   seisman

   on May 5, 2021

   Member

   More actions

   I think we should update the series settings for makecpt accordingly in the examples.

   I agree. I think we also need to add a colorbar to these examples. We didn't do that before, because GMT 6.1.1 has some bugs/limitations when plotting categorical colorbars, which should be fixed in GMT 6.2.0rc1.

   👍React with 👍1Reacted by Michael Grund
5. maxrjones commented on May 5, 2021

   

   maxrjones

   on May 5, 2021

   Member

   More actions

   I think we should update the series settings for makecpt accordingly in the examples.

   I agree. I think we also need to add a colorbar to these examples. We didn't do that before, because GMT 6.1.1 has some bugs/limitations when plotting categorical colorbars, which should be fixed in GMT 6.2.0rc1.

   Agreed. Are you interested in updating the examples @michaelgrund? I can submit a PR if you are not interested or do not have time.
6. seisman

   added

   documentationImprovements or additions to documentationImprovements or additions to documentation

   and removed

   bugSomething isn't workingSomething isn't working

   on May 5, 2021
7. seisman

   added this to the 0.4.0 milestone on May 5, 2021
8. michaelgrund commented on May 6, 2021

   

   michaelgrund

   on May 6, 2021

   MemberAuthor

   More actions

   I think we should update the series settings for makecpt accordingly in the examples.

   I agree. I think we also need to add a colorbar to these examples. We didn't do that before, because GMT 6.1.1 has some bugs/limitations when plotting categorical colorbars, which should be fixed in GMT 6.2.0rc1.

   Agreed. Are you interested in updating the examples @michaelgrund? I can submit a PR if you are not interested or do not have time.

   I will work on that the upcoming weekend and will open a corresponding PR @meghanrjones.
9. seisman

   changed the title [-]Color deviations after switching to GMT 6.2.0rc1[/-] [+]Add categorical colorbars for plot and plot3d gallery examples[/+] on May 9, 2021
10. michaelgrund

    added a commit that references this issue on May 10, 2021

    WIP: Add categorical colorbars for plot and plot3d gallery examples

    ...

    5d6c480
11. michaelgrund

    linked a pull request that will close this issueAdd categorical colorbars for plot, plot3d and line colors gallery examples #1267on May 10, 2021
12. seisman

    closed this as completedin #1267on May 13, 2021