chore(vela-e2e): trim redundant tests, remove unused reqwest dep - #219
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the vela-e2e workspace test surface by removing redundant cross-crate tests (that duplicate unit coverage) and by dropping an unused direct dependency to keep the crate lean.
Changes:
- Removed multiple redundant E2E tests across suites 1–6, focusing the crate on true cross-crate invariants.
- Simplified suite scopes/docs and pruned no-longer-needed imports.
- Removed the unused
reqwestdependency fromvela-e2e.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vela/vela-core/crates/vela-e2e/src/suite6_config.rs | Drops orchestrator/pipeline duplication; keeps timeout, error-conversion, and watchdog invariant checks. |
| src/vela/vela-core/crates/vela-e2e/src/suite5_error_recovery.rs | Removes redundant hub/slot/lifecycle tests; keeps timeout + watchdog fallback chain coverage. |
| src/vela/vela-core/crates/vela-e2e/src/suite4_pipeline.rs | Removes duplicated ordering/display/config checks; retains terminal-state + lifecycle transition tests. |
| src/vela/vela-core/crates/vela-e2e/src/suite3_hub_retry.rs | Removes redundant download/client/url tests; keeps retry + checksum + serde coverage. |
| src/vela/vela-core/crates/vela-e2e/src/suite2_slot_lifecycle.rs | Removes redundant slot manager and metrics tests; keeps lifecycle progression + mock slot detect/swap E2E. |
| src/vela/vela-core/crates/vela-e2e/src/suite1_watchdog_bus.rs | Removes redundant displayability test; keeps event bus lifecycle/subscriber/history coverage. |
| src/vela/vela-core/crates/vela-e2e/Cargo.toml | Removes unused direct reqwest dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
65
to
67
| vela_slotmgr::SlotId::Alternate | ||
| ); | ||
| } |
| @@ -131,31 +36,7 @@ fn test_lifecycle_config_timeouts_reasonable() { | |||
| assert!(installing >= Duration::from_secs(600)); | |||
- Reduce e2e test count by removing tests that duplicate unit coverage - Remove unused reqwest dependency from vela-e2e (compile time win) - Gate e2e test modules behind #[cfg(test)] to skip them in lib builds - Split CI test job into unit-test (20min timeout) and e2e-test (30min timeout) - Add job-level timeouts to prevent 6-hour hangs - Add --test-threads for test parallelization
JusterZhu
force-pushed
the
chore/trim-e2e-tests
branch
from
May 21, 2026 11:07
2a4084d to
7565595
Compare
… hangs on Linux CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce workspace test count from 165 to 133 (-19%). Remove unused reqwest dep and 32 redundant e2e tests that duplicate unit tests.