Add the skill lifecycle hooks to the Trace mappings - #63
Conversation
Signed-off-by: Saba Siddique <sabasiddiqdev@gmail.com>
Signed-off-by: Saba Siddique <sabasiddiqdev@gmail.com>
|
@rocklambros and @afogel Please guide on the following
|
Signed-off-by: Saba Siddique <sabasiddiqdev@gmail.com>
Signed-off-by: Saba Siddique <sabasiddiqdev@gmail.com>
|
@rocklambros and @afogel Please guide on the following
|
What changed
skillRegister,skillLoad, andskillUnloadhad no entry inotel-mapping.jsonorocsf-mapping.json, so a deployment claiming ACS-Trace had no normative span name or class_uid for a skill event. This adds both mappings, renders them on the Trace Events and Extending OCSF pages, correctsdocs/acs.mdfrom 16 to 19 hooks, and widenstests/test_hook_taxonomy.pyto cover every surface that restates the hook set. Closes #57, closes #58.Type of change
Specification changes
Breaking for implementers? No. Nothing on the wire changes. Three new keys appear in each mapping's
default; existing keys, span names, and class assignments are untouched.OTel:
acs.skill.register,acs.skill.load,acs.skill.unload. Required attributes come from each schema'srequiredlist.acs.skill.load_pathstays required because cascade containment is the reason the hook carries it.OCSF, reviewer decision:
skillRegisterandskillUnloadare Inventory Info (5001), the classagbom/*uses, since they admit a skill to or remove it from the component set and the unload schema already allows folding intoagbom/changed.skillLoadis Process Activity (1007), sibling oftoolCallRequest. A deniedskillRegisterstill surfaces as Detection Finding 2004 throughdecision_class. The alternative is 1005 Module Activity (Load=1, Unload=2), which fits load and unload directly and reuses the activity_id pattern used for 3002.Guard
The first commit widens the test and fails on exactly the surfaces #58 lists, plus one it did not: the class table in
extend_ocsf.mdnever listedsteps/agentTrigger. That row is fixed here too.Not changed
The AgBOM trigger list in
docs/spec/inspect/README.mdomitsskill; separate issue. The "Sixteen" inspecification/proposals/skill-lifecycle/README.mddescribes the pre-skill state and is correct in context. Legacy example content indocs/acs.mdandOCSF/implementation_examples.mdis out of scope.Checklist
git commit -s(required by the DCO)uv run mkdocs build --strictpassesSecurity
Full suite: 203 passed, 1 skipped.