Repository navigation
feat(server): stop uploads from filling the server's disk, and say so plainly to every client - #537
Merged
Merged
Conversation
A jobs key could fill the data volume with parallel uploads or kept audio: nothing checked free space before or while an upload was written. Every multipart upload now keeps the 1 GB a model download keeps, checked before the first byte and every 16 MB while the body arrives.
…t is down The forwarding primary read any 5xx as a remote that is down and sent the job again; the dictation remote counted it toward its down-probe and said the remote was down. A 507 now fails or keeps the job here like a 422, and the dictation falls back saying the remote's disk is full.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…s it A remote whose disk is under its floor is skipped for one probe period, so a job it refused goes to the next remote that offers it instead of failing or running here. With no other remote, the job still runs here or fails with the reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A
jobskey could fill the server's data volume. Nothing checked free space before or while an upload was written. The queue check cannot see uploads still arriving, and kept audio (keep_audio) is never swept. Once the disk is full, the job store and every other key stop working.Fix
Every multipart upload now keeps 1 GB free on the volume of its upload folder. This is the same margin a model download keeps (SV-M2).
insufficient_storagebefore it reads the body. The answer givesfree_bytesandfloor_bytes.remote disk full, used fast.akou transcribeandakou_transcribeprint the server's reason. The CLI exits 70, not 69 (unavailable).Not in this change
Testing
[DSK-F1]and[DSK-F2], also added to docs/TRAPS.md. They cover the refusal before the body, the cut mid-body with no file left, the OpenAI-compatible route, the CLI, the MCP tool, the forwarding primary and the dictation remote. The positive controls are the same upload with room, and a 503 that still counts as down.check:staticpasses. The touched suites pass: multipart, upload floor, remote dispatch, dictation remote, jobs, OpenAI, Bazarr, upload idle, security, OpenAPI and docs.