Skip to content

refactor(live): build the family page and pedigree in og - #544

Open
geiresx wants to merge 4 commits into
GeiserX:mainfrom
geiresx:pgp/port-live-family
Open

geiresx wants to merge 4 commits into
GeiserX:mainfrom
geiresx:pgp/port-live-family

Conversation

@geiresx

@geiresx geiresx commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

The live site's family page was still built in Python. bin/owngenome_live_family.py read every family table itself, bin/pedigree_svg.py drew the pedigree, and bin/family_report.py was kept alive for its readers. That is the last big piece of the live site's family code outside og.

The fix

  • og live family builds the family page in Rust. Its verbs give a family's state (state), family.json (page), the families for the run list (families), the files a family serves (files) and pedigree.svg (svg).
  • og-pedigree gains the layout and the SVG drawing that pedigree_svg.py did. The SVG is the same byte for byte.
  • bin/owngenome_live_family.py is now a relay: it passes the site's runs, step 23 candidates and member summaries to og live family page and serves what og returns. Without og, family.json answers 500, pedigree.svg answers 503, and the run list marks each family unreadable.
  • bin/pedigree_svg.py, bin/family_report.py, tests/test_pedigree_svg.py and tests/test_live_family_depth.py are removed. Their checks moved to rust/crates/og-live/tests/family_layout.rs and family_page.rs. Each check also runs on a planted mistake and must fail there.
  • tests/demo/build_live_demo.py builds the demo's family.json and pedigree through og.

How it was checked

  • Parity with the old Python code (the tree at 4ee60e6), on the demo family, the live fixtures and the family fixtures: 105 comparisons of state, family.json, pedigree.svg, the files list, the site page with runs, candidates and summaries, the families list, the side-by-side shapes and an unreadable file. 0 differ. The same harness on a copy of the old code with planted mistakes reports 26 differences and exits 1.
  • cargo test -p og-live -p og-pedigree: all pass, family_layout 8 tests and family_page 17 tests among them. cargo clippy --all-targets -D warnings and cargo fmt --check are clean.
  • Red first: with the pedigree step moved by one unit, 2 layout tests fail. With the compound-het order and the "summary not readable" words changed in family.rs, 3 page tests fail.
  • tests/test_family_report.py and tests/test_live_results.py pass against the new og (the family.json wording gate runs through the relay).
  • The family browser checks in tests/test_owngenome_live_family.py and tests/test_live_demo.py run in CI.

Bead: D1

The layout and the SVG drawing that bin/pedigree_svg.py did, ported to
og-pedigree's layout module: the same generations, couples, sibships
and descent lines, and an SVG byte for byte the same.

Bead: D1
og live family state, page, families, files and svg give the family's
state, family.json, the run list's families, the files a family serves
and pedigree.svg. The cargo tests carry the checks of the Python tests
this replaces, each with a planted mistake it must catch.

Bead: D1
The family plugin asks og live family for every page it serves; the
Python pedigree drawing and family report code and their tests are
removed.

Bead: D1
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3748117 and f841f79.

Files ignored due to path filters: 3

  • rust/Cargo.lock is excluded by !**/*.lock
  • scripts/ci/e2e-case-paths.tsv is excluded by !**/*.tsv
  • tests/parity/remnants.tsv is excluded by !**/*.tsv
Files selected for processing: 13

  • CHANGELOG.md
  • bin/family_report.py
  • bin/owngenome_live_family.py
  • bin/pedigree_svg.py
  • rust/crates/og-live/Cargo.toml
  • rust/crates/og-live/src/family.rs
  • rust/crates/og-live/tests/family_layout.rs
  • rust/crates/og-live/tests/family_page.rs
  • rust/crates/og-pedigree/src/layout.rs
  • tests/demo/build_live_demo.py
  • tests/test_family_report.py
  • tests/test_live_family_depth.py
  • tests/test_pedigree_svg.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants