Repository navigation
Conversation
The layout and the SVG drawing that bin/pedigree_svg.py did, ported to og-pedigree's layout module: the same generations, couples, sibships and descent lines, and an SVG byte for byte the same. Bead: D1
og live family state, page, families, files and svg give the family's state, family.json, the run list's families, the files a family serves and pedigree.svg. The cargo tests carry the checks of the Python tests this replaces, each with a planted mistake it must catch. Bead: D1
The family plugin asks og live family for every page it serves; the Python pedigree drawing and family report code and their tests are removed. Bead: D1
# Conflicts: # CHANGELOG.md
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 51 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live site's family page was still built in Python.
bin/owngenome_live_family.pyread every family table itself,bin/pedigree_svg.pydrew the pedigree, andbin/family_report.pywas kept alive for its readers. That is the last big piece of the live site's family code outside og.The fix
og live familybuilds the family page in Rust. Its verbs give a family's state (state),family.json(page), the families for the run list (families), the files a family serves (files) andpedigree.svg(svg).pedigree_svg.pydid. The SVG is the same byte for byte.bin/owngenome_live_family.pyis now a relay: it passes the site's runs, step 23 candidates and member summaries toog live family pageand serves what og returns. Without og,family.jsonanswers 500,pedigree.svganswers 503, and the run list marks each family unreadable.bin/pedigree_svg.py,bin/family_report.py,tests/test_pedigree_svg.pyandtests/test_live_family_depth.pyare removed. Their checks moved torust/crates/og-live/tests/family_layout.rsandfamily_page.rs. Each check also runs on a planted mistake and must fail there.tests/demo/build_live_demo.pybuilds the demo'sfamily.jsonand pedigree through og.How it was checked
state,family.json,pedigree.svg, the files list, the site page with runs, candidates and summaries, the families list, the side-by-side shapes and an unreadable file. 0 differ. The same harness on a copy of the old code with planted mistakes reports 26 differences and exits 1.cargo test -p og-live -p og-pedigree: all pass,family_layout8 tests andfamily_page17 tests among them.cargo clippy --all-targets -D warningsandcargo fmt --checkare clean.family.rs, 3 page tests fail.tests/test_family_report.pyandtests/test_live_results.pypass against the new og (the family.json wording gate runs through the relay).tests/test_owngenome_live_family.pyandtests/test_live_demo.pyrun in CI.Bead: D1