Skip to content

style: fix earnfm.py formatting#75

Merged
GeiserX merged 1 commit into
mainfrom
fix/earnfm-format
May 23, 2026
Merged

style: fix earnfm.py formatting#75
GeiserX merged 1 commit into
mainfrom
fix/earnfm-format

Conversation

@GeiserX
Copy link
Copy Markdown
Owner

@GeiserX GeiserX commented May 23, 2026

Removes trailing newline that broke ruff format check.

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling in earnings collection to consistently report errors with appropriate error messages and zero balance.

Review Change Stack

@GeiserX GeiserX merged commit 64677b4 into main May 23, 2026
1 check passed
@GeiserX GeiserX deleted the fix/earnfm-format branch May 23, 2026 20:12
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4a992215-3180-42e3-b9d9-0702b51157a9

📥 Commits

Reviewing files that changed from the base of the PR and between 9e80688 and d6a5a2f.

📒 Files selected for processing (1)
  • app/collectors/earnfm.py

📝 Walkthrough

Walkthrough

The error handling path in EarnFMCollector.collect was corrected to ensure failed attempts return an EarningsResult with consistent field values: balance=0.0 and error=str(exc).

Changes

Error handling normalization

Layer / File(s) Summary
Exception handler EarningsResult fields
app/collectors/earnfm.py
EarningsResult returned on exception now includes balance=0.0 and error=str(exc) for consistent failure-case representation.

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/earnfm-format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant