Rename the commit task to "Commit & Push", ignore build artifacts - #6
Merged
Conversation
The task button said "Commit", which reads as *my work is safe* while the commit sat inside a Codespace that can be deleted. It now pushes as well (Gefyra/igpublisher-devcontainer-image#3) and the label says so. The task also ran `git add -A` over a repository that did not ignore `json-resources.zip` — a file the sibling "Download: JSON Resources" task produces — so one click on each button committed a build artifact. That file and `.idea/` are ignored now. Renamed in tasks.json, in the task button in settings.json and in both READMEs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EXNRSuZCTZ897kqXgaj3x6
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EXNRSuZCTZ897kqXgaj3x6
Contributor
Deployment |
The commit task stages everything, which is what lets it be a single button, and the README did not say where to go when that is the wrong tool. It now names VS Code's Source Control panel for picking individual files or reading a diff first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EXNRSuZCTZ897kqXgaj3x6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two problems with the commit button, one of them a live bug.
It committed build artifacts.
git add -Aran over a repository that did not ignorejson-resources.zip— the file the sibling "Download: JSON Resources" task creates. One click on each button was enough to commit it..idea/had the same problem.Its name overpromised. "Commit" reads as my work is saved, while the commit stayed inside a Codespace that can be deleted.
What changed
.gitignorecoversjson-resources.zipand.idea/.tasks.json, in the task button insettings.json, and in both READMEs.The behaviour behind it lives in the image: Gefyra/igpublisher-devcontainer-image#3 makes
ig-commitlist what it staged and push withgit push -u origin HEAD.Verification
json-resources.zip.idea/output/full-ig.zipgit add -Ain a working treetasks.json,settings.jsonNote
Merge Gefyra/igpublisher-devcontainer-image#3 and let the image rebuild first. Until then the renamed task calls an
ig-committhat commits without pushing — which works, but does not do what the new label says.🤖 Generated with Claude Code
https://claude.ai/code/session_01EXNRSuZCTZ897kqXgaj3x6