Preserve imported Arc workspace items - #65
Open
Luo-hongyi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Before this change, importing from Arc Browser could parse the Arc sidebar data but still fail to bring the imported workspaces and items into Arcmark correctly during the apply step.
Fix
This change preserves the imported node tree when creating each workspace during Arc import, instead of creating an empty workspace first and then re-adding nodes one by one.
Result
After this change, Arc import works correctly.
Verification
swift test --filter ModelTests.testCreateWorkspaceWithInitialItemsPersistsTreeswift test --filter ArcImportTests