Skip to content

Transition From GH Secrets To Vault Secrets#518

Merged
dchansen06 merged 18 commits into
mainfrom
VaultSecrets
Jun 30, 2026
Merged

Transition From GH Secrets To Vault Secrets#518
dchansen06 merged 18 commits into
mainfrom
VaultSecrets

Conversation

@dchansen06

@dchansen06 dchansen06 commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Migrate To Vault Secrets

Problem and Scope

GH Secrets are hard to manage

Description

Acquire secrets from GR Vault

Gotchas and Limitations

GR Vault must work correctly

Testing

  • HOOTL testing
  • HITL testing
  • Human tested

Testing Details

Actions work as expected

Larger Impact

Forward replace secrets easier

Additional Context and Ticket

Resolves #516

@dchansen06
Migrate autogen
b6b1eb7 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06
Migrate autoformat
eb6dfd0 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06 dchansen06 self-assigned this Jun 27, 2026
@dchansen06 dchansen06 added Documentation Improvements or additions to documentation Enhancement New feature or request GitHub Meta, anything related to or dealing with GitHub Small Fry Something that is small, could include bug fixes or smaller changes 3 NORMAL Important but not really a priority labels Jun 27, 2026
@dchansen06 dchansen06 added this to the Monorepo Niceties milestone Jun 27, 2026
@dchansen06
Fix permissions for id-token
c70b857 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
BK1031
BK1031 reviewed Jun 27, 2026
View reviewed changes
Comment thread .github/workflows/AutoFormat.yml Outdated
dchansen06 and others added 4 commits June 26, 2026 22:14
@dchansen06
Swap to auto latest since it is a GR managed action
c60d423 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06
Attempt to not persist credentials
34fefac 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@BK1031
ci: configure formatter git credentials after checkout
85686e0
@dchansen06
Validate autoformat still works
b87f7f9 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06 dchansen06 marked this pull request as ready for review June 27, 2026 05:39
@dchansen06

dchansen06 commented Jun 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

See .github/workflows/deploy.yml in Gaucho-Racing/Vault for reference

@dchansen06 dchansen06 marked this pull request as draft June 30, 2026 08:39
@dchansen06
Try to diagnose autogen secret
8c00d69 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06
Diagnose PAT validity
6cfc470 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06
Fix validity diagnosis
076822c 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06

dchansen06 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Might just be really dumb

$ echo "***" | gh auth login --with-token 
error validating token: HTTP 401: Bad credentials (https://api.github.com/)

@dchansen06
Extract secret safely
29eac3b 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06
Too long
fe54523 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06
Simplify vault usage
d151268 
Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06 dchansen06 marked this pull request as ready for review June 30, 2026 09:18
@dchansen06

dchansen06 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Might just be really dumb

Yeah, see Discord

@dchansen06
Use explicit versioning so that all actions can be forced to use expl…
552d12a 
…icit versioning

Signed-off-by: Daniel Hansen <dchansen06@gmail.com>
@dchansen06 dchansen06 merged commit caae916 into main Jun 30, 2026
41 checks passed
@dchansen06 dchansen06 deleted the VaultSecrets branch June 30, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BK1031 BK1031 BK1031 left review comments

Assignees

@dchansen06 dchansen06

Labels

3 NORMAL Important but not really a priority Documentation Improvements or additions to documentation Enhancement New feature or request GitHub Meta, anything related to or dealing with GitHub Small Fry Something that is small, could include bug fixes or smaller changes

Projects

None yet

Milestone

Monorepo Niceties

Development

Successfully merging this pull request may close these issues.

Migrate Autoformat Secret To Vault Secrets

2 participants

@dchansen06 @BK1031