Skip to content

fix(fastdl): include Source resource files - #4953

Open
BreezeDelegate wants to merge 1 commit into
GameServerManagers:developfrom
BreezeDelegate:fix/fastdl-resource
Open

fix(fastdl): include Source resource files#4953
BreezeDelegate wants to merge 1 commit into
GameServerManagers:developfrom
BreezeDelegate:fix/fastdl-resource

Conversation

@BreezeDelegate

Copy link
Copy Markdown

Description

Include the Source resource directory in FastDL and copy its mixed client assets instead of looking for the non-existent resources directory.

Fixes #3992

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Testing

  • Commands/tests run: isolated fn_fastdl_preview and fn_fastdl_source fixtures; bash -n; npx prettier --check lgsm/modules/command_fastdl.sh; ShellCheck
  • Result: preview and copy both handled 3/3 mixed resource files; all checks passed
  • Environment used (distro/version): Ubuntu 24.04

Risk and rollback

  • Risk level: low
  • Rollback plan: revert this change

Breaking changes

  • No breaking changes.
  • Breaking changes included (describe below).

Documentation impact

  • No documentation update required.
  • User documentation update required.
  • Developer documentation update required.

Checklist

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have provided a detailed enough description of this PR.

Copilot AI lite review requested due to automatic review settings August 24, 2026 11:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes FastDL packaging for Source engine servers by including the correct resource/ directory (not the non-existent resources/) and ensuring its client assets are copied into the FastDL output.

Changes:

  • Update the Source FastDL directory list to use resource instead of resources.
  • Treat resource/ as “copy all files” (-iname "*") during both preview and copy steps.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants