fix(fastdl): include Source resource files - #4953
Open
BreezeDelegate wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes FastDL packaging for Source engine servers by including the correct resource/ directory (not the non-existent resources/) and ensuring its client assets are copied into the FastDL output.
Changes:
- Update the Source FastDL directory list to use
resourceinstead ofresources. - Treat
resource/as “copy all files” (-iname "*") during both preview and copy steps.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include the Source
resourcedirectory in FastDL and copy its mixed client assets instead of looking for the non-existentresourcesdirectory.Fixes #3992
Type of change
Testing
fn_fastdl_previewandfn_fastdl_sourcefixtures;bash -n;npx prettier --check lgsm/modules/command_fastdl.sh; ShellCheckresourcefiles; all checks passedRisk and rollback
Breaking changes
Documentation impact
Checklist