feat: roll in Frank's overlay-support updates#2
Merged
Conversation
…ebug Adds an unmistakable INFO line at the very start of Device::Device that prints a build timestamp (__DATE__ __TIME__). When a user reports DEVICE_LOST on Mali and this line is missing from logcat, that unambiguously means CMake reused a cached lsfg-vk-framegen.a — the actual storage-image-features fix is not on the device. The build stamp variable is referenced from Device::Device so the linker can't dead-strip it. Also adds a hard WARN-level log when the physical device reports shaderStorageImageExtendedFormats=FALSE. That feature is what the LSFG compute chain needs for R16G16B16A16_SFLOAT storage image access; without it, dispatch is undefined behavior and the queue dies on first present. This is a runtime confirmation of the root cause, not a fix — the DEVICE_LOST warning text points future debug effort at shader rework, not device-creation tweaks. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…rt legacy Vulkan devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source
Validation
cmake -S . -B build-pr-checkcmake --build build-pr-check -j8(environment stops early here because local Vulkan headers are not installed:vulkan/vulkan.hnot found)