Skip to content

fix(hotfix): 热更桥接去启动基类继承并更名生命周期桥接 - #616

Merged
AlianBlank merged 1 commit into
mainfrom
feature/auto-server-source-worker-run-11494-20261022T0400
Oct 22, 2026
Merged

fix(hotfix): 热更桥接去启动基类继承并更名生命周期桥接#616
AlianBlank merged 1 commit into
mainfrom
feature/auto-server-source-worker-run-11494-20261022T0400

Conversation

@AlianBlank

@AlianBlank AlianBlank commented Oct 22, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Linear: GFX-987

Summary by CodeRabbit

  • 重构
    • 调整热更新模块的生命周期管理方式；首次加载仍会应用当前配置并激活相关组件，模块重载行为保持不变。
  • 变更
    • 移除原有的网关连接启动流程，包括自动重连、服务器注册和心跳处理。

@AlianBlank
fix(hotfix): 热更桥接去启动基类继承并更名生命周期桥接
4b26e05 
C284 把监听与漏斗迁往宿主后，AppStartUpHotfixGame 对
AppStartUpBase 的继承全为死重（no-op StartAsync、宿主已执行的
冗余装配、无人触碰的就绪屏障与退出令牌），且顶着启动 Role 身份
误导读者。去继承并更名迁移为 internal sealed
HotfixModuleLifecycleBridge（GameFrameX.Hotfix/Lifecycle/，
命名空间 GameFrameX.Hotfix.Lifecycle），删除 ByGateWay 注释
死块；Init 内非冗余的 GlobalSettings.SetCurrentSetting 显式
化保留——多 Role 进程（AllInOne）下把 CurrentSetting 钉回首
启动 Role，且必须早于统一消息发送器构造固化本服身份，行为等价。
移除 GameFrameX.Hotfix 对 GameFrameX.StartUp 的项目引用，热更
程序集引用表不再含启动程序集；IHotfixBridge 公开契约不变。

Linear: GFX-987
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3893583b-f3f3-47c1-b4bd-6ac205308561
📥 Commits

Reviewing files that changed from the base of the PR and between a6747ed and 4b26e05.

📒 Files selected for processing: 7
  • CHANGELOG.md
  • GameFrameX.Core/Session/PlayerDisconnectedEventArgs.cs
  • GameFrameX.Hotfix/GameFrameX.Hotfix.csproj
  • GameFrameX.Hotfix/Lifecycle/HotfixModuleLifecycleBridge.cs
  • GameFrameX.Hotfix/Logic/ServerRole/SessionResume/PlayerDisconnectedEventListener.cs
  • GameFrameX.Hotfix/StartUp/AppStartUpHotfixGameByGateWay.cs
  • GameFrameX.Launcher/StartUp/AppStartUpGame.cs
+------------------------------------------------------------------+
| Series-B funding secured. Now, I can afford to review your code. |
+------------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Oct 22, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@AlianBlank
AlianBlank merged commit cc91ac3 into main Oct 22, 2026
2 of 3 checks passed
@AlianBlank
AlianBlank deleted the feature/auto-server-source-worker-run-11494-20261022T0400 branch October 22, 2026 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@AlianBlank