Skip to content

feat(exec): opt into grevm deterministic skip of tx-level-invalid txns #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Richard1048576 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(exec): opt into grevm deterministic skip of tx-level-invalid txns #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,12 @@ reth-provider = { path = "crates/storage/provider" }
reth-prune = { path = "crates/prune/prune" }
reth-prune-types = { path = "crates/prune/types", default-features = false }
reth-revm = { path = "crates/revm", default-features = false }
grevm = { package = "grevm", git = "https://github.com/Galxe/grevm", rev = "2a42859a56f03197fce5be4ceb475d9f1a7d7c3d" }
# grevm#110's `with_skip_invalid_txn` opt-in (consumed below). NOTE: grevm main is on revm 40 but
# gravity-reth is on revm 29, so #110's PR head (revm 40) is NOT consumable here — this pins the
# revm-29 backport of the same feature (Richard1048576/grevm `feat/skip-invalid-txn-optin-revm29`),
# which also carries the parallel-path commit-detected-skip fix. Re-point to a Galxe/grevm commit
# once the revm-29-vs-40 alignment is decided (backport upstreamed, or gravity-reth upgraded).
grevm = { package = "grevm", git = "https://github.com/Galxe/grevm", rev = "d0d0911ee0ca5ca7397325c9fd42d87710521e7c" }
reth-rpc = { path = "crates/rpc/rpc" }
reth-rpc-api = { path = "crates/rpc/rpc-api" }
reth-rpc-api-testing-util = { path = "crates/rpc/rpc-testing-util" }
Expand Down
10 changes: 9 additions & 1 deletion crates/ethereum/evm/src/parallel_execute.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,15 @@ where
state,
false,
self.custom_precompiles.clone(),
);
)
// Downgrade a tx-level-invalid tx (EVMError::Transaction — e.g. NonceTooLow from an
// EIP-7702 delegate-then-CREATE nonce double-bump) from a whole-block panic to a
// deterministic per-tx skip in grevm's sequential fallback. Closes the
// execution-induced halt class that the pre-execution filter fundamentally cannot
// model (gravity-audit#838, durable close-out of #823). This is an STF change (a bad
// tx goes halt -> skip); deploy behind a coordinated upgrade. Requires grevm built
// with `with_skip_invalid_txn` (Galxe/grevm#110).
.with_skip_invalid_txn(true);
executor.parallel_execute(None).map_err(|e| {
// `e.txid` is grevm's per-tx index; for block-level errors it can be a
// sentinel or out-of-bounds value. Use a saturating lookup so the error
Expand Down
Loading