bugfix: fix network inbound queue delay underflow - #80
Open
Lchangliang wants to merge 1 commit into
Open
Conversation
Lchangliang
marked this pull request as ready for review
August 6, 2026 01:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
ReceivedMessage::new()recordsreceive_timestamp_microsusing Unix wall-clock time, andreceived_message_to_event()later reads Unix wall-clock time again before observing inbound queue delay. If the system clock moves backwards between those two reads, or a manually constructedReceivedMessagecarries a future receive timestamp,dequeue_at - rx_atunderflows and can panic.Validation
cargo fmt --package aptos-networkgit diff --checkcargo test -p aptos-network inbound_queue_delay_seconds