Repository navigation
fix(insights): keep window controls last in toolbar - #124
Merged
GaganSD merged 4 commits intoNov 16, 2026
Merged
Conversation
The installer refused any layout whose tab bar is a personal clone (content.mod other than "tabs"), and when it did install it placed the Insights button after the tab bar. On Windows and Linux the tab bar draws minimize/maximize/close at its own end (window().buttons), so the button landed after them and the window buttons were no longer last. - accept any mod-backed "tabs" block, not just Herdr's own tabs mod - place the button before the bar on Windows/Linux and after it on macOS, where a leading button would collide with the traffic lights - inject the platform so both placements are covered by tests, and cover a cloned tab bar end to end - update INSTALL.md, README.md and the development guide
Keep the approach from this PR (accept a cloned tab bar; lead with the button off macOS so the bar's own minimize/maximize/close stay last) and trim it to the composition function, its unit test, and the two docs that specify the layout. - reverse the two children instead of restructuring the row - drop the installer integration test and fixture; the layout unit test covers both placements and a cloned bar - move the docs to INSTALL.md and RECIPE.md, which define the layout; the README and development guide wording still holds - update RECIPE.md, whose child-order spec was left stale Refs GaganSD#123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #123
Summary
tabsblock backed by any mod, so a personal clone of the tab bar (tabs-graph, ...) can be wrapped instead of refused.INSTALL.mdand update the child-order spec inRECIPE.md.Scope
The change is limited to
withInsightsToolbar()inherdr-insights/scripts/toolbar.mjs, its unit test, and the two docs that define the layout (4 files). An earlier revision of this PR also edited the README and development guide and added an installer integration test with a new fixture; those were dropped as redundant.Notes
Validation
npm run test:insights(310 passing, macOS)npx eslint herdr-insights/scripts/toolbar.mjs tests/herdr-insights/toolbar-layout.test.mjs