Update Default Minimum Zoom Levels - #106
Merged
Merged
Conversation
Algent
previously requested changes
Sep 6, 2026
Algent
left a comment
There was a problem hiding this comment.
For the fluid the minimum zoom was chosen because I made the code interact with the "top label" somewhat cleanly with it (it move out of the way). But I can kind accept this one.
For the min zoom on ore label I'm very opposed at changing the default value.
Your example picture is the proof it overlap half of the ore mixes names.
If someone really want to be in that suboptimal they can just edit the conf for themselves.
|
With the added offset this is all good for me (and it kinda make the dev vote moot) but since I pushed on your branch I'll let someone else approve. |
Algent
approved these changes
Sep 8, 2026
Algent
left a comment
There was a problem hiding this comment.
All things considered diff is fairly small so I'll just approve it even if I also touched it ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1) The current defaults require you to zoom in uncomfortably far to see ore vein names and fluid reservoir amounts. Lowering the defaults makes it much nicer to read since the information still appears from farther out. The only downside is that it slightly encourages overlapping text, but there's always the option to zoom in.
MINIMUM ZOOM LEVELS BEFORE vs. AFTER (FLUIDS)
MINIMUM ZOOM LEVELS BEFORE vs. AFTER (ORES)
Part 2) The advertised L/Op values were equivalent to the original amounts at a 1:1 ratio. However, without any overclocks the L/Op of Fluid Drilling Rigs is only half of the amount. This PR therefore divides the amount by two before rendering it on the JourneyMap.
The T1 Fluid Drilling Rig
Current L/Op values on JourneyMap
Fixed L/Op values on JourneyMap
Checklist