Skip to content

Update Default Minimum Zoom Levels - #106

Merged
Dream-Master merged 7 commits into
masterfrom
fox/config
Sep 8, 2026
Merged

Dream-Master merged 7 commits into
masterfrom
fox/config

Conversation

@DylanTaylor1

@DylanTaylor1 DylanTaylor1 commented Sep 6, 2026 •

Copy link
Copy Markdown

Part 1) The current defaults require you to zoom in uncomfortably far to see ore vein names and fluid reservoir amounts. Lowering the defaults makes it much nicer to read since the information still appears from farther out. The only downside is that it slightly encourages overlapping text, but there's always the option to zoom in.

MINIMUM ZOOM LEVELS BEFORE vs. AFTER (FLUIDS)

image image

MINIMUM ZOOM LEVELS BEFORE vs. AFTER (ORES)

image image

Part 2) The advertised L/Op values were equivalent to the original amounts at a 1:1 ratio. However, without any overclocks the L/Op of Fluid Drilling Rigs is only half of the amount. This PR therefore divides the amount by two before rendering it on the JourneyMap.

image

The T1 Fluid Drilling Rig

image

Current L/Op values on JourneyMap

image

Fixed L/Op values on JourneyMap

image

Checklist

  • I have tested this PR in DevEnv
  • I have tested this PR in Fullpack
  • This PR is in compliance with the GTNH AI Policy
  • This PR requires another PR in order to merge

@DylanTaylor1 DylanTaylor1 added Safe for Stable Bugfix with low break chance for patch releases Chore Buildscript update, dep update, adaptation to trivial breaking changes, etc. labels Sep 6, 2026
@DylanTaylor1 DylanTaylor1 added Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it. and removed Chore Buildscript update, dep update, adaptation to trivial breaking changes, etc. labels Sep 6, 2026
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

#107

Algent
Algent previously requested changes Sep 6, 2026

@Algent Algent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the fluid the minimum zoom was chosen because I made the code interact with the "top label" somewhat cleanly with it (it move out of the way). But I can kind accept this one.

For the min zoom on ore label I'm very opposed at changing the default value.
Your example picture is the proof it overlap half of the ore mixes names.
If someone really want to be in that suboptimal they can just edit the conf for themselves.

@Algent
Algent dismissed their stale review September 7, 2026 09:18

Added offset instead

@Algent

Algent commented Sep 7, 2026

Copy link
Copy Markdown

With the added offset this is all good for me (and it kinda make the dev vote moot) but since I pushed on your branch I'll let someone else approve.

@Algent Algent left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All things considered diff is fairly small so I'll just approve it even if I also touched it :shipit:

@Dream-Master
Dream-Master merged commit 26244cd into master Sep 8, 2026
1 check passed
@Dream-Master
Dream-Master deleted the fox/config branch September 8, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Fixes a bug. Please link it in the PR if an issue exists for it. Safe for Stable Bugfix with low break chance for patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants