Command formatting - #164
Merged
Merged
Conversation
added 2 commits
August 2, 2026 03:02
Connor-Colenso
added
Chore
Connor-Colenso
force-pushed
the
formatNumbers
branch
from
August 5, 2026 01:06
ce3ed40 to
6cd07fb
Compare
cubefury
requested changes
Aug 5, 2026
cubefury
left a comment
cubefury
left a comment
Collaborator
There was a problem hiding this comment.
Hello, thank you for your PR!
Codewise looks good, just some minor rewording of the langkeys is needed. I think some of the logical subclassing of the commands is a little excessive, eg. add.chat.add.all.currency.response -> add.all_currency.response. I've indicated a couple other examples in the langfile itself, but it applies in general to most of the new langkeys you've added.
Thanks for the help!
Connor-Colenso
force-pushed
the
formatNumbers
branch
from
August 5, 2026 16:22
6cd07fb to
84d17f5
Compare
Connor-Colenso
force-pushed
the
formatNumbers
branch
from
August 5, 2026 16:40
84d17f5 to
13cb86e
Compare
Author
|
Cleaned up the lang entries and removed the 0 case, defaults to just add now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some clean up of command handling. Introduces proper localisation, number formatting and some safeguards. This project has a chinese lang file so would be nice if someone can translated my lang entries for that at some point.