Conversation
This commit checks if the game profile is complete first, before calling `canSendCommands`, which does not do the check and explodes on null. In practice this should fix weird fakeplayer interactions like thaumcraft golems breaking/placing blocks in claimed chunks. And keep the logs clean of endless stacktraces :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Commit itself has some info, but briefly, I think this actually fixes GTNewHorizons/GT-New-Horizons-Modpack#20295, aka don't crash and burn on weird incomplete fakeplayer actions (think thaumcraft golems) in claimed chunks.
Not only does this fix the issue, it also keeps the console clean, because right now it just spams an exception every tick something tries to do something (which results in very lengthy logs without much substance).
I did not test this fix on current version, since I am currently playing through the latest stable (where serverutils are 2.2.2) and so I made the patch originally for that version, but applied there it works beautifully. I skimmed the recent commits and I don't think there's anything interfering with this fix, so I just rebased it on master.
Seems like the original ftbutils ended up doing something similar, but I wasn't able to trace it to a commit.
Checklist